Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various additions #35

Merged
merged 8 commits into from
Jan 13, 2021
Merged

Various additions #35

merged 8 commits into from
Jan 13, 2021

Conversation

dsferruzza
Copy link
Member

@dsferruzza dsferruzza commented Jan 9, 2021

@dsferruzza dsferruzza changed the title Add setting to persist UI locale Various additions Jan 9, 2021
@dsferruzza
Copy link
Member Author

@valeriansaliou This work is not finished yet!

I added the UiLocale struct in the locale.rs file as "a bunch of helper functions/traits to ease building the value of the UiLocale control messages".
➡️ What do you think of this first implementation? Do you miss something here?

@valeriansaliou
Copy link
Member

valeriansaliou commented Jan 9, 2021

LGTM. Except that I wouldnt name it UiLocale but simply Locale as it's really the locale code for the whole MakAir system, we don't need to be specific that it's only currently used by the UI.

@dsferruzza dsferruzza merged commit 79fe676 into master Jan 13, 2021
@dsferruzza dsferruzza deleted the various-additions branch January 13, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants