Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry message for factory end of line test #34

Open
Benhalor opened this issue Jan 1, 2021 · 2 comments
Open

telemetry message for factory end of line test #34

Benhalor opened this issue Jan 1, 2021 · 2 comments

Comments

@Benhalor
Copy link

Benhalor commented Jan 1, 2021

A new type of message should be added to send messages from the firmware to the UI during the factory end of line test
The following informations should be in this message :

  • uint16_t stepNumber
  • uint8_t stepStatus : 0 = fail, 1 = success, 2 = in progress
  • String message : a string to display on the UI. No translation required because this is only a factory mode
  • some numbers should be send, but due to the fact, that the amount and type of theses numbers is different at each message, it would be easier to send the numbers as text in the String message
  • bool lastMessage : true if this is the last message

On the other direction, the UI should be able to send message to the firmware when the user clicks on the "NEXT" button

@dsferruzza dsferruzza mentioned this issue Jan 9, 2021
6 tasks
@dsferruzza
Copy link
Member

  1. I assume this new telemetry message would be send at a constant frequency and the current state changes, right?
  2. Not sure about the success status value: receiving a message saying that step i is in progress should tell the UI that every step < i was a success, thus making the success status useless, right?
  3. What will the UI do with the numbers? If this data is not structured now, it does not mean the firmware will be able to send whatever it wants, it just means that the UI will have to somehow parse it if it needs it (while I believe it should be the telemetry lib's job)
  4. What is the point of the lastMessage field?

@dsferruzza
Copy link
Member

This is not done yet, we need to define what data is sent in case of EOL success

@dsferruzza dsferruzza reopened this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants