feat: adds optional confirmation dialogs for emergency stop and power device change #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… device change Signed-off-by: Pedro Lamas <[email protected]>
|
thank you very much! this is a loooooooong time on my todolist... but no time for it! feel free to make more of this PRs.... |
|
Thank you for the quick review and merge!! 😁 |
|
Thank you! I hugely appreciate you taking the time to add this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #114 , by adding two new options on the General Settings that allow to enable an optional confirmation dialog for Emergency Stop and Power Device changes.
Note: this mimics a PR I previously to Fluidd (fluidd-core/fluidd#388).
Signed-off-by: Pedro Lamas [email protected]