Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds optional confirmation for power device toggle #388

Merged

Conversation

pedrolamas
Copy link
Member

Implements #386, by adding a new setting that allow to indicate if a confirmation dialog should be shown when the user toggles a device power.

Signed-off-by: Pedro Lamas [email protected]

Copy link
Contributor

@dweight dweight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Contributor

@eduncan911 eduncan911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eduncan911 eduncan911 merged commit bc32627 into fluidd-core:develop Jan 25, 2022
@pedrolamas pedrolamas deleted the pedrolamas/power-device-confimation branch January 25, 2022 23:07
@matmen matmen added this to the Release: 1.17 milestone Feb 22, 2022
matmen pushed a commit to matmen/fluidd that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI - QoL Improvements to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants