Adds unit tests to cart reducer #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
jimbo
approved these changes
Mar 4, 2019
supernova-at
added a commit
that referenced
this pull request
Mar 6, 2019
supernova-at
pushed a commit
that referenced
this pull request
Mar 7, 2019
* Create script for generating reference docs from source code * Fix develop script bug that makes the server reload continuously after a change * Clean up reference table template * Use new auto-generated content in topics * Update docblocks in source * Add clean command to scripts to prevent usage of stale content between develop runs * Run prettier * Adds unit tests to app reducer (#921) * Adds unit tests to app reducer * Updates tests to be less fragile * Add unit tests to cart reducer (#928) * Adds unit tests to catalog reducer (#931) * [DOCUMENTATION] cherry pick 3.0 doc updates (#992) * Fixed typo mistake (#939) * Fixed typo mistake (#969) * Scroll to top on Product mount (#832) * Create new guest cart when checkout resets (#917)
supernova-at
pushed a commit
that referenced
this pull request
Mar 21, 2019
* Merge branch 'release/2.0' of /home/d.shmaliuk/pwa-studio with conflicts. * "Remove Item" in Minicart usability issue #661. Added loading element in MiniCart, after delete item. * "Remove Item" in Minicart usability issue #661. Added check for loadingElement object. * "Remove Item" in Minicart usability issue #661. Added check for loadingElement object. * "Remove Item" in Minicart usability issue #661. Added check for loadingElement object. * Adds unit tests to app reducer (#921) * Adds unit tests to app reducer * Updates tests to be less fragile * Add unit tests to cart reducer (#928) * Adds unit tests to catalog reducer (#931) * [DOCUMENTATION] cherry pick 3.0 doc updates (#992) * Fixed typo mistake (#939) * Fixed typo mistake (#969) * Scroll to top on Product mount (#832) * Create new guest cart when checkout resets (#917) * Purchase History unit tests and refactors (#891) * Simplifies and adds tests to purchaseHistory throughout the app * Simplifies and adds tests to purchaseHistory throughout the app * Adds snapshot test to PurchaseHistory Filter component * Mask specific product instead of entire cart during removeItem action * Remove unnecessary stuff. * Cleanup code and extra additions. * "Remove item" in minicart usability issue #661 Solved problem in file kebab.js * [FEATURE] "Remove item" in minicart usability issue Refactoring minicart.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit tests to
reducers/cart.js.It also does a little refactoring for sanity sake, as the reducer was returning state containing both a
loadingand anisLoading, which were for two completely different purposes. I renamed them and updated any code that needed to reflect the new names.Related Issue
Closes #922 .
Motivation and Context
Part of the ongoing effort to increase unit test coverage in Venia.
How Has This Been Tested?
yarn test. See that the coverage numbers are at 100%.Screenshots (if appropriate):
Proposed Labels for Change Type/Package
TEST
venia-conceptChecklist: