Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Remove Item" in Minicart usability issue #661

Closed
2 of 10 tasks
codeAdrian opened this issue Dec 13, 2018 · 1 comment · Fixed by #882
Closed
2 of 10 tasks

"Remove Item" in Minicart usability issue #661

codeAdrian opened this issue Dec 13, 2018 · 1 comment · Fixed by #882
Labels
enhancement New feature or request pkg:venia-concept userexperience Issue concerns the user experience of a workflow, rather than code bugs.

Comments

@codeAdrian
Copy link
Contributor

This issue is for the following packages:

  • venia-concept
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec

This issue is a:

  • Bug
  • Feature suggestion
  • Documentation issue
  • Other (Please Specify)

Environment

Question Answer
Magento version 2.3
Operating System + version macOS 10.13.6
node.js version (node -v) v8.11.3
npm version (npm -v) 5.6.0

Description

There is an usability issue when user clicks on "Remove Item" in minicart. Steps to reproduce:

  1. User adds 2 or more different items in cart. For example:
    screen shot 2018-12-13 at 1 49 39 pm
  2. For the last item in the list, user clicks "Remove item" from the actions list
  3. The request is being sent in background, this takes some time.
  4. While that is happening in the background, user can still interact with that minicart item, so user clicks on the "Remove item" several more times for the same item.
  5. Now all products are removed from the cart, even though user kept clicking "Remove item" for the last item in the list.

Expected result:

User shouldn't be able to interact with cart items (or the particular items which is being removed) while the request is processing.

Possible solutions:

Overlay a spinner on top of the minicart items to visually indicate that the request is being processed and disallow users to interact with the minicart items. @soumya-ashok , feel free to suggest an alternative solution.
@codeAdrian codeAdrian changed the title "Remove Item" in Minicart Usability Issue "Remove Item" in Minicart usability issue Dec 13, 2018
@ericerway ericerway added enhancement New feature or request userexperience Issue concerns the user experience of a workflow, rather than code bugs. pkg:venia-concept labels Dec 18, 2018
@dmshm
Copy link
Contributor

dmshm commented Feb 4, 2019 •
edited
Loading

Please, assign me.

@dmshm dmshm mentioned this issue Feb 11, 2019
Merged
8 tasks
supernova-at pushed a commit that referenced this issue Mar 21, 2019
@dmshm @supernova-at
[FEATURE] "Remove item" in minicart usability issue (#882)
4b82402 
* Merge branch 'release/2.0' of /home/d.shmaliuk/pwa-studio with conflicts.

* "Remove Item" in Minicart usability issue #661.
Added loading element in MiniCart, after delete item.

* "Remove Item" in Minicart usability issue #661.
Added check for loadingElement object.

* "Remove Item" in Minicart usability issue #661.
Added check for loadingElement object.

* "Remove Item" in Minicart usability issue #661.
Added check for loadingElement object.

* Adds unit tests to app reducer (#921)

* Adds unit tests to app reducer
* Updates tests to be less fragile

* Add unit tests to cart reducer (#928)

* Adds unit tests to catalog reducer (#931)

* [DOCUMENTATION] cherry pick 3.0 doc updates (#992)

* Fixed typo mistake (#939)

* Fixed typo mistake (#969)

* Scroll to top on Product mount (#832)

* Create new guest cart when checkout resets (#917)

* Purchase History unit tests and refactors (#891)

* Simplifies and adds tests to purchaseHistory throughout the app

* Simplifies and adds tests to purchaseHistory throughout the app

* Adds snapshot test to PurchaseHistory Filter component

* Mask specific product instead of entire cart during removeItem action

* Remove unnecessary stuff.

* Cleanup code and extra additions.

* "Remove item" in minicart usability issue #661
Solved problem in file kebab.js

* [FEATURE] "Remove item" in minicart usability issue
Refactoring minicart.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request pkg:venia-concept userexperience Issue concerns the user experience of a workflow, rather than code bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bug] "Remove item" in minicart usability issue
3 participants
@ericerway @codeAdrian @dmshm