-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dev): Hide spam warnings from babel-plugin-module-resolver #881
Conversation
This pull request is automatically deployed with Now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tleunen/babel-plugin-module-resolver/pull/351 is merged. Can you update this PR accordingly?
Totally agree. 👍 Please review the plugin PR and let's get this updated and merged! |
Oh nice! Updating now. |
4f2fbea
to
5a44d2c
Compare
@sirugh How's this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. I built it locally, did not see the warnings, and the app served as expected.
Description
Fixes #880. We use an interceptor API for the plugin's
resolvePath
function, which simulates the environment variable while the plugin runs. This works and suppresses the warning, so we removed the explanatorconsole.warn()
call as well.Related Issue
Closes #880.
Motivation and Context
Devex is a primary quality measure of this project, and useless worrisome console output is one of the worst things for devex.
How Has This Been Tested?
Tested in all environments and Node versions.
Screenshots (if appropriate):
Compare to screeshot in #880:
Proposed Labels for Change Type/Package
BUG
Improved devex
Affects venia-concept, even though changes are in root babel.config.js
Checklist: