Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): add loglevel to configure console logging #351

Merged

Conversation

zetlen
Copy link
Contributor

@zetlen zetlen commented Jan 30, 2019

  • Add loglevel option
  • Disable missing path warning if loglevel is "silent"

We use this plugin to export a "virtual dependency" in our published modules, so that consumers of our module can override a deep dependency. We then alias the virtual module in Webpack config, not babel config. So we expect the virtual module not to exist at Babel build time.

Your plugin works great (thank you!) but it logs a lot of warnings due to our configuration, so we'd appreciate this option to quiet them.

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #351 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/normalizeOptions.js 100% <100%> (ø) ⬆️
src/resolvePath.js 100% <100%> (ø) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #351 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/normalizeOptions.js 100% <100%> (ø) ⬆️
src/resolvePath.js 100% <100%> (ø) ⬆️

@tleunen
Copy link
Owner

tleunen commented Feb 11, 2019

I don't see why we couldn't have a log level option. Thank you for adding the documentation as well!

@tleunen tleunen merged commit d4a596c into tleunen:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants