BUG#3982 Add uid instead of id in noProductsFound.js #3982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hello @Jordaneisenburger , Can you please check this PR that have only one check left. |
dupadhyay3
changed the title
dupadhyay3
changed the title
|
Hello @anthoula, Can you please check this too? |
anthoula
added
the
version: Patch
anthoula
approved these changes
Nov 2, 2022
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
anthoula
approved these changes
Nov 2, 2022
|
run cypress |
|
Successfully started codebuild job for |
|
run pr-test |
|
Successfully started codebuild job for |
LogERROR ON TASK: cypressTests |
|
QA Aprroved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have already deprecated id field and we will replace it with uid changes but there is still missing one place in category page if there is no products for category then below component is called that used category.id instead of category.uid. Id is not there in object that gives console warning for key.
So we have updated from id to uid that gives unique value for each category and resolved the browser console warning.
Related Issue
Closes #3981.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist