-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: Add uid instead of id in noProductsFound.js #3981
Labels
Comments
Hi @dupadhyay3. Thank you for your report. Add a comment to assign the issue:
|
@magento I am working on this |
@adobe export issue to JIRA project PWA as Bug |
✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3013 is successfully created for this GitHub issue. |
anthoula
added
the
needs-triage
A pull request or issue that needs to be triaged prior to being synced to JIRA
label
Oct 25, 2022
github-jira-sync-bot
added
Progress: ready for grooming
Progress: ready for dev
and removed
needs-triage
A pull request or issue that needs to be triaged prior to being synced to JIRA
Progress: ready for grooming
labels
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
We have already deprecated id field and we will replace it with uid changes but there is still missing one place in category page if there is no products for category then below component is called that used category.id instead of category.uid. due to id is not there in object that gives console warning for key.
**@magento/venia-ui/lib/RootComponents/Category/NoProductsFound/noProductsFound.js
https://github.com/magento/pwa-studio/blob/develop/packages/venia-ui/lib/RootComponents/Category/NoProductsFound/noProductsFound.js#L31
Only changes of UID will automatically gets the latest changes as per unique identifier.
To reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Possible solutions
Add any ideas about possible solutions to the problem here.
Debug Report
Paste the output of
yarn build:report
, and any other context about the problem, here.Please complete the following device information:
<![](-- Complete the following sections to help us apply appropriate labels) -->
Please let us know what packages this bug is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
Test Plan
NOTE - No browser or device testing needed for this pr given no UI changes
The text was updated successfully, but these errors were encountered: