Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Add uid instead of id in noProductsFound.js #3981

Closed
dupadhyay3 opened this issue Oct 17, 2022 · 4 comments · Fixed by #3982
Closed

[bug]: Add uid instead of id in noProductsFound.js #3981

dupadhyay3 opened this issue Oct 17, 2022 · 4 comments · Fixed by #3982
Assignees
Labels
bug Something isn't working Progress: done

Comments

@dupadhyay3
Copy link
Member

dupadhyay3 commented Oct 17, 2022

Describe the bug

We have already deprecated id field and we will replace it with uid changes but there is still missing one place in category page if there is no products for category then below component is called that used category.id instead of category.uid. due to id is not there in object that gives console warning for key.

**@magento/venia-ui/lib/RootComponents/Category/NoProductsFound/noProductsFound.js
https://github.com/magento/pwa-studio/blob/develop/packages/venia-ui/lib/RootComponents/Category/NoProductsFound/noProductsFound.js#L31

Only changes of UID will automatically gets the latest changes as per unique identifier.

To reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Possible solutions

Add any ideas about possible solutions to the problem here.

Debug Report

Paste the output of yarn build:report, and any other context about the problem, here.

Please complete the following device information:

  • Device <e.g. iPhone6, PC, Mac, Pixel3>:
  • Browser <e.g. Chrome, Safari>:
  • Browser Version <e.g. 22>:
  • Magento Version <e.g Adobe Commerce 2.4>:

<![](-- Complete the following sections to help us apply appropriate labels) -->

Please let us know what packages this bug is in regards to:

  • < > venia-concept
  • venia-ui
  • < > pwa-buildpack
  • < > peregrine
  • < > pwa-devdocs
  • < > upward-js
  • < > upward-spec
  • < > create-pwa

Test Plan

  • Verify Category page loads with. products
  • Create an empty category and navigate to it and verify UID is present instead of ID.
  • On category apply filters and verify UID is present when filter results in products and also when filters results in no products.
  • Verify same on Search pages for category filter with and without filters
  • Verify existing cypress test CI job passes.
    NOTE - No browser or device testing needed for this pr given no UI changes
@dupadhyay3 dupadhyay3 added the bug Something isn't working label Oct 17, 2022
@m2-assistant
Copy link

m2-assistant bot commented Oct 17, 2022

Hi @dupadhyay3. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


@dupadhyay3
Copy link
Member Author

@magento I am working on this

@anthoula
Copy link
Contributor

@adobe export issue to JIRA project PWA as Bug

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3013 is successfully created for this GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Progress: done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants