Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-2791::Current state of custom controls not announced. (Shopping Bag) #3792

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

glo71317
Copy link
Collaborator

@glo71317 glo71317 commented Apr 26, 2022

Description

Current state of custom controls not announced. (Shopping Bag)

Reproduction Steps
select "Blouses & Shirts" > select "Susanna Draped Tank" > add product to cart > select bag > select "Edit Shopping Bag" - [NODE][body>div:nth-of-type(1)>:nth-child(1)>:nth-child(3)]

  1. With JAWS operating, press Tab to move through the content.
  2. When keyboard focus is on accordion, press Enter or Space to activate it.

Actual Behavior
Custom controls do not announce the current state of expanded or collapsed.
When controls do not provide name, role and/or state, screen reader users will not know their purpose and current state. Examples include:

Actions menu
Accordions

Expected Behavior
For each accordion which has multiple states (ie expanded, collapsed), ensure the state is communicated to let the user know what will occur when they interact with the accordion. Use the aria-expanded attribute on the button that triggers the expansion, set to true or false to communicate the expanded state.

Related Issue

Closes https://jira.corp.magento.com/browse/AC-2791.

Verification Steps

Pre-Conditions:

  1. Have Magento instance with sample data installed
  2. Make sure to have pwa studio installed
  3. Make sure to have a customer login for front end login

Manual Steps executed:

Login to venia > Navigate to global header accessories or other
Add product to cart > select bag > select "Edit Shopping Bag"
Enable your screen reader and press Tab to move focus through each accordion content which has multiple states (ie expanded, collapsed), ensure the state is communicated to let the user know what will occur when they interact with the accordion.

✖️ Behaviour Before The Fix : Custom controls do not announce the current state of expanded or collapsed.

✔️Behaviour After The Fix: Custom controls do announce the current state of expanded or collapsed.

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

Resolved issues:

  1. resolves [Issue] AC-2791::Current state of custom controls not announced. (Shopping Bag) #3831: AC-2791::Current state of custom controls not announced. (Shopping Bag)

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Apr 26, 2022

Messages
📖

Associated JIRA tickets: AC-2791.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 94e5a12

@glo71317
Copy link
Collaborator Author

glo71317 commented May 2, 2022

run all tests

@supernova-at
Copy link
Contributor

@magento create issue from PR

@anthoula anthoula added the version: Patch This changeset includes backwards compatible bug fixes. label Sep 15, 2022
anthoula
anthoula previously approved these changes Sep 15, 2022
@anthoula anthoula changed the base branch from GL-web-accessibility to develop September 15, 2022 21:36
@anthoula anthoula dismissed their stale review September 15, 2022 21:36

The base branch was changed.

@magento magento deleted a comment from pwa-studio-bot Sep 15, 2022
@magento magento deleted a comment from pwa-studio-bot Sep 15, 2022
@magento magento deleted a comment from pwa-studio-bot Sep 15, 2022
@magento magento deleted a comment from pwa-studio-bot Sep 15, 2022
@anthoula
Copy link
Contributor

run all tests

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 15, 2022

Successfully started codebuild job for the following test suites:

lighthouse-desktop
lighthouse-mobile
pr-test
scaffold-pwa
cypress

@magento magento deleted a comment from pwa-test-bot bot Sep 15, 2022
@dpatil-magento
Copy link
Contributor

run lighthouse-desktop

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 16, 2022

Successfully started codebuild job for lighthouse-desktop

@dpatil-magento
Copy link
Contributor

run lighthouse-mobile

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 16, 2022

Successfully started codebuild job for lighthouse-mobile

@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Sep 16, 2022

Successfully started codebuild job for cypress

@dpatil-magento dpatil-magento merged commit c414ae3 into magento:develop Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] AC-2791::Current state of custom controls not announced. (Shopping Bag)
5 participants