-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-2791::Current state of custom controls not announced. (Shopping Bag) #3792
Conversation
|
run all tests |
@magento create issue from PR |
run all tests |
Successfully started codebuild job for the following test suites:
|
run lighthouse-desktop |
Successfully started codebuild job for |
run lighthouse-mobile |
Successfully started codebuild job for |
run cypress |
Successfully started codebuild job for |
Description
Current state of custom controls not announced. (Shopping Bag)
Reproduction Steps
select "Blouses & Shirts" > select "Susanna Draped Tank" > add product to cart > select bag > select "Edit Shopping Bag" - [NODE][body>div:nth-of-type(1)>:nth-child(1)>:nth-child(3)]
Actual Behavior
Custom controls do not announce the current state of expanded or collapsed.
When controls do not provide name, role and/or state, screen reader users will not know their purpose and current state. Examples include:
Actions menu
Accordions
Expected Behavior
For each accordion which has multiple states (ie expanded, collapsed), ensure the state is communicated to let the user know what will occur when they interact with the accordion. Use the aria-expanded attribute on the button that triggers the expansion, set to true or false to communicate the expanded state.
Related Issue
Closes https://jira.corp.magento.com/browse/AC-2791.
Verification Steps
Pre-Conditions:
Manual Steps executed:
Login to venia > Navigate to global header accessories or other
Add product to cart > select bag > select "Edit Shopping Bag"
Enable your screen reader and press Tab to move focus through each accordion content which has multiple states (ie expanded, collapsed), ensure the state is communicated to let the user know what will occur when they interact with the accordion.
✖️ Behaviour Before The Fix : Custom controls do not announce the current state of expanded or collapsed.
✔️Behaviour After The Fix: Custom controls do announce the current state of expanded or collapsed.
Checklist
Resolved issues: