Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] AC-2791::Current state of custom controls not announced. (Shopping Bag) #3831

Closed
m2-assistant bot opened this issue May 4, 2022 · 2 comments · Fixed by #3792
Closed

[Issue] AC-2791::Current state of custom controls not announced. (Shopping Bag) #3831

m2-assistant bot opened this issue May 4, 2022 · 2 comments · Fixed by #3792

Comments

@m2-assistant
Copy link

m2-assistant bot commented May 4, 2022

This issue is automatically created based on existing pull request: #3792: AC-2791::Current state of custom controls not announced. (Shopping Bag)


Description

Current state of custom controls not announced. (Shopping Bag)

Reproduction Steps
select "Blouses & Shirts" > select "Susanna Draped Tank" > add product to cart > select bag > select "Edit Shopping Bag" - [NODE][body>div:nth-of-type(1)>:nth-child(1)>:nth-child(3)]

  1. With JAWS operating, press Tab to move through the content.
  2. When keyboard focus is on accordion, press Enter or Space to activate it.

Actual Behavior
Custom controls do not announce the current state of expanded or collapsed.
When controls do not provide name, role and/or state, screen reader users will not know their purpose and current state. Examples include:

Actions menu
Accordions

Expected Behavior
For each accordion which has multiple states (ie expanded, collapsed), ensure the state is communicated to let the user know what will occur when they interact with the accordion. Use the aria-expanded attribute on the button that triggers the expansion, set to true or false to communicate the expanded state.

Related Issue

Closes https://jira.corp.magento.com/browse/AC-2791.

Verification Steps

Pre-Conditions:

  1. Have Magento instance with sample data installed
  2. Make sure to have pwa studio installed
  3. Make sure to have a customer login for front end login

Manual Steps executed:

Login to venia > Navigate to global header accessories or other
Add product to cart > select bag > select "Edit Shopping Bag"
Enable your screen reader and press Tab to move focus through each accordion content which has multiple states (ie expanded, collapsed), ensure the state is communicated to let the user know what will occur when they interact with the accordion.

✖️ Behaviour Before The Fix : Custom controls do not announce the current state of expanded or collapsed.

✔️Behaviour After The Fix: Custom controls do announce the current state of expanded or collapsed.

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.
@supernova-at
Copy link
Contributor

@magento export issue to JIRA project PWA as Story

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/PWA-2813 is successfully created for this GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants