Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AC-2493::Items within actions menu are not operable for keyboard-only… #3791

Merged
merged 7 commits into from
Sep 1, 2022
Merged

AC-2493::Items within actions menu are not operable for keyboard-only… #3791

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e0e5b0d
AC-2493::Items within actions menu are not operable for keyboard-only…
glo71317 Apr 26, 2022
2da6261
AC-2788:updated the snapshot because tests are failing
glo71317 May 2, 2022
e172aad
Merge remote-tracking branch 'origin/develop' into AC-2493_v1
jcalcaben Aug 29, 2022
a93a4b0
Fix screen reader not reading menu buttons
jcalcaben Aug 30, 2022
098b62a
Enable focus outline on kebab menu
jcalcaben Aug 30, 2022
334acf0
Enable focus outline on kebab menu
jcalcaben Aug 30, 2022
4c8b11b
Run prettier
jcalcaben Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ia-ui/lib/components/CartPage/ProductListing/__tests__/__snapshots__/product.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ exports[`renders configurable product with options 1`] = `
>
<button
className="button"
onMouseDown={[MockFunction]}
onClick={[MockFunction]}
>
<span
className="root"
Expand Down Expand Up @@ -301,7 +301,7 @@ exports[`renders configurable product with options 1`] = `
>
<button
className="button"
onMouseDown={[MockFunction]}
onClick={[MockFunction]}
>
<span
className="root"
Expand Down Expand Up @@ -600,7 +600,7 @@ exports[`renders out of stock product 1`] = `
>
<button
className="button"
onMouseDown={[MockFunction]}
onClick={[MockFunction]}
>
<span
className="root"
Expand Down Expand Up @@ -899,7 +899,7 @@ exports[`renders simple product correctly 1`] = `
>
<button
className="button"
onMouseDown={[MockFunction]}
onClick={[MockFunction]}
>
<span
className="root"
Expand Down
4 changes: 4 additions & 0 deletions packages/venia-ui/lib/components/LegacyMiniCart/kebab.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,7 @@
composes: border-0 from global;
composes: outline-none from global;
}

.kebab:focus {
border: 1px solid rgb(115, 115, 115);
}
2 changes: 1 addition & 1 deletion packages/venia-ui/lib/components/LegacyMiniCart/section.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const Section = props => {
<li className={classes.menuItem} {...restProps}>
<button
className={classes.button}
onMouseDown={onClick}
onClick={onClick}
data-cy="LegacyMiniCart-Section-button"
>
<Icon classes={iconClasses} size={16} src={iconSrc} />
Expand Down