-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-2493::Items within actions menu are not operable for keyboard-only… #3791
Conversation
… users (Shopping Bag)
|
run all tests |
@magento create issue from PR |
The base branch was changed.
run pr-deploy |
Successfully started codebuild job for |
run pr-test |
Successfully started codebuild job for |
run cypress |
Successfully started codebuild job for |
Now screen reader announce list items but still there are things like Kebab menu just say button instead of informative text. But its not part of this ticket so merging it once CI jobs pass. |
Description
Items within actions menu are not operable for keyboard-only users (Shopping Bag)
Reproduction Steps
select "Blouses & Shirts" > select "Susanna Draped Tank" > add product to cart > select bag > select "Edit Shopping Bag" - [NODE][body>div:nth-of-type(1)>:nth-child(1)>:nth-child(3)]
Actual Behavior
There are actionable elements that are not functional with the keyboard alone. Examples include:
Within actions menu:
"Move to favorites"
"Edit Item"
"Remove from cart"
Keyboard-only users cannot access this functionality. (Note that these controls can be activated when a screen reader is operating.)
Expected Behavior
Ensure that all functionality can be activated using keyboard alone.
Related Issue
Closes https://jira.corp.magento.com/browse/AC-2493
Verification Steps
Pre-Conditions:
Manual Steps executed:
Login to venia > select any product and add it to cart > select bag > select "Edit Shopping Bag"
Press Tab to move through the content.
When keyboard focus is on options (3 dots/"kebab") menu for a cart item, press Enter or Space to activate it.
Tab through each item in the options menu and press Enter or Space to activate.
✖️ Behaviour Before The Fix : There are actionable elements that are not functional with the keyboard alone. Examples include:
Within actions menu:
"Edit Item"
"Remove from cart"
✔️Behaviour After The Fix: All functionalities are activated using keyboard alone.
Checklist
Resolved issues: