Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes accordion section buttons to type button #2335

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Changes accordion section buttons to type button #2335

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ec112a
Changes accordion section buttons to type button
supernova-at Apr 14, 2020
4d71701
Merge branch 'develop' into supernova/accordion_buttons
dpatil-magento Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/venia-ui/lib/components/Accordion/__tests__/__snapshots__/accordion.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ exports[`it renders a closed Section correctly 1`] = `
<button
className="title_container"
onClick={[Function]}
type="button"
>
<span
className="title_wrapper"
Expand Down Expand Up @@ -59,6 +60,7 @@ exports[`it renders an open Section correctly 1`] = `
<button
className="title_container"
onClick={[Function]}
type="button"
>
<span
className="title_wrapper"
Expand Down
1 change: 1 addition & 0 deletions packages/venia-ui/lib/components/Accordion/section.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const Section = props => {
<button
className={classes.title_container}
onClick={handleSectionToggleWithId}
type="button"
>
<span className={classes.title_wrapper}>
<span className={classes.title}>{title}</span>
Expand Down
3 changes: 3 additions & 0 deletions ...omponents/CartPage/PriceAdjustments/__tests__/__snapshots__/priceAdjustments.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ exports[`it renders Venia price adjustments 1`] = `
<div>
<button
onClick={[Function]}
type="button"
>
<span>
<span>
Expand Down Expand Up @@ -37,6 +38,7 @@ exports[`it renders Venia price adjustments 1`] = `
<div>
<button
onClick={[Function]}
type="button"
>
<span>
<span>
Expand Down Expand Up @@ -69,6 +71,7 @@ exports[`it renders Venia price adjustments 1`] = `
<div>
<button
onClick={[Function]}
type="button"
>
<span>
<span>
Expand Down