Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes accordion section buttons to type button #2335

Merged
merged 2 commits into from
Apr 14, 2020
Merged

Changes accordion section buttons to type button #2335

merged 2 commits into from
Apr 14, 2020

Conversation

supernova-at
Copy link
Contributor

Description

button elements that do not submit forms should have type="button".
This PR fixes the Accordion Section buttons, which did not.

Related Issue

Closes PWA-524.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Go to the /cart or /checkout page where an Accordion is rendered (the Price Adjustments section)
  2. Inspect element
  3. See that the section buttons have type="button"

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@supernova-at supernova-at added the version: Patch This changeset includes backwards compatible bug fixes. label Apr 14, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Apr 14, 2020 •
edited
Loading

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PWA-524.

Generated by 🚫 dangerJS against 4d71701

@dpatil-magento dpatil-magento merged commit ef55ef5 into develop Apr 14, 2020
@dpatil-magento dpatil-magento deleted the supernova/accordion_buttons branch April 14, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirugh sirugh sirugh approved these changes

Assignees

@sirugh sirugh

Labels
pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@supernova-at @PWAStudioBot @sirugh @dpatil-magento