-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Pass rest attributes to radio group items #2313
[feature] Pass rest attributes to radio group items #2313
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've converted this component into a functional component but your changes should still apply. Please consider my comment and resolve the merge conflict :)
Signed-off-by: sirugh <[email protected]>
Signed-off-by: sirugh <[email protected]>
8bd4ec5
to
ef9cfbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a unit test before @dpatil-magento notices.
@@ -23,6 +23,18 @@ stories.add('With a message', () => { | |||
return <RadioGroup items={items} message={'I am a message.'} />; | |||
}); | |||
|
|||
stories.add('with disabled items', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: sirugh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the first six label/value pairs didn't catch a bug, surely the seventh will 😂Thanks for adding a test.
Description
Forwarding additional attributes to Radio component using RadioGroup.
Related Issue
Closes #2270.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Screenshots / Screen Captures
Checklist