We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug When using the RadioGroup component, we cannot specify if its items are disabled or not.
https://github.com/magento/pwa-studio/blob/develop/packages/venia-ui/lib/components/RadioGroup/radioGroup.js#L34 In the RadioGroup component, the items only accepts a label and a value.
Expected behavior We should have a way to render the Radio items as disabled or not.
Possible solutions We could pass additional attributes to the item via an attributes key of the items prop.
const options = items.map(({ label, value, attributes }) => ( <Radio classes={{ label: classes.radioLabel, root: classes.radio }} key={value} label={label} value={value} {...attributes} /> )); /* --- */ const items = [ { label: 'Enabled item', value: 'value_1' }, { label: 'Disabled item', value: 'value_2', attributes: { disabled: true } } ]; /* --- */ <RadioGroup field="disabled_example" items={items} />
Please complete the following device information:
6.11.3
10.17.0
Please let us know what packages this bug is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
The text was updated successfully, but these errors were encountered:
Good value add and relatively low LOE, moving to prioritized for pickup by interested community member(s)
Sorry, something went wrong.
larsroettig
LucasCalazans
Successfully merging a pull request may close this issue.
Describe the bug
When using the RadioGroup component, we cannot specify if its items are disabled or not.
https://github.com/magento/pwa-studio/blob/develop/packages/venia-ui/lib/components/RadioGroup/radioGroup.js#L34
In the RadioGroup component, the items only accepts a label and a value.
Expected behavior
We should have a way to render the Radio items as disabled or not.
Possible solutions
We could pass additional attributes to the item via an attributes key of the items prop.
Please complete the following device information:
6.11.3
10.17.0
Please let us know what packages this bug is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
The text was updated successfully, but these errors were encountered: