Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Owls] PB-55: Row Full Width Contents Are Horizontally Positioned Incorrectly In Desktop Viewport #2146

Merged
merged 4 commits into from
Feb 14, 2020

Conversation

cspruiell
Copy link
Contributor

Description

Contents are not correctly aligning horizontally when inside a Full-Width appearance Row. The contents are aligning to what would be the very edge of a Contained Row. Instead, they should align with the elements inside the contained row. This is fixed by moving the padding from the main row element, to the "inner" row element and is not backwards compatible. A framework to provide a data patch for the backwards incompatible change is introduced in the related PRs: magento/magento2-page-builder#378 and https://github.com/magento/magento2-page-builder-ee/pull/107

Related Issue

PB-55 Row Full Width Contents Are Horizontally Positioned Incorrectly In Desktop Viewport

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Create Page Builder content with one contained row containing a button. Duplicate that row and change the appearance from contained to Full Width.
  2. Verify the buttons in each row are aligned
  3. Make sure any similar content created previously to this patch is corrected by running the related data patch found in the other PRs.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Feb 6, 2020

Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Associated JIRA tickets: PB-55.

Generated by 🚫 dangerJS against fa99dfb

@sirugh
Copy link
Contributor

sirugh commented Feb 6, 2020

This may want to wait for #2137 to get merged as it moves all of PB to a different folder and updates imports. Shouldn't bee too hard to deal with regardless of the order this gets merged though.

cc @zetlen

@davemacaulay davemacaulay added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Feb 13, 2020
@davemacaulay davemacaulay merged commit d269e50 into magento:develop Feb 14, 2020
@davemacaulay davemacaulay deleted the PB-55 branch June 1, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:venia-ui version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants