[Owls] PB-370: Introduce upgrade mechanism for Page Builder content #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y In Desktop Viewport
…y In Desktop Viewport
- add wrapper classes
- add PhpGt DOM library
…y In Desktop Viewport - fix functional tests
- update wrapper classes
- adjust composer.json
- update wrapper classes
- upgrade framework and data patch for PB-55
…ry' into PB-370-Introduce-upgrade-mechanism Conflicts: app/code/Magento/PageBuilder/Model/Dom/Adapter/ElementInterface.php app/code/Magento/PageBuilder/Model/Dom/Adapter/HtmlCollectionInterface.php app/code/Magento/PageBuilder/composer.json
- move utility function to Document class - replace usage of ObjectManager with Factory
|
@magento run all tests |
cspruiell
changed the title
davemacaulay
suggested changes
Feb 10, 2020
| @@ -23,12 +23,12 @@ class Document implements DocumentInterface | |||
| /** | |||
| * @var ObjectManagerInterface | |||
| */ | |||
| private $objectManager; | |||
| protected $objectManager; | |||
There was a problem hiding this comment.
protected anything is disallowed, can we work around this?
- fix content upgrade
- add large content case to test
- skip elements that does not have padding - add more cases to test
…' into PB-370-Introduce-upgrade-mechanism
|
MHI approved:
|
omiroshnichenko
approved these changes
Feb 14, 2020
davemacaulay
approved these changes
Feb 14, 2020
|
@magento run all tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Story
Builds
All-User-Requested-Tests
Related Pull Requests
https://github.com/magento/magento2-page-builder-ee/pull/107
Checklist