Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stringify cookie value to fix Google Analyitcs Tracking and Cookie Overlay #5596 #9713

Merged
merged 1 commit into from
May 24, 2017

Conversation

bka
Copy link
Contributor

@bka bka commented May 20, 2017

Description

There seems to be a problem in module-cookie/view/frontend/web/js/notices.js. After confirming the cookie restriction dialog, the value "[object Object]" gets saved, which cannot be evaluated anymore in _getAcceptedSaveCookiesWebsites in module-cookie/Helper/Cookie.php

Fixed Issues (if relevant)

  1. Google Universal Analytics does not track when Cookie Restriction is enabled  #5596: Google Universal Analytics does not track when Cookie Restriction is enabled
  2. Google Analytics Tracking Code cached by Varnish if Cookie Restriction Settings are active #6441: Cookie Restriction Mode Overlay should not be cached by Varnish

Manual testing scenarios

auswahl_052
auswahl_053

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this May 20, 2017
@ishakhsuvarov ishakhsuvarov added this to the May 2017 milestone May 20, 2017
@magento-team magento-team merged commit a4daf56 into magento:develop May 24, 2017
magento-team pushed a commit that referenced this pull request May 24, 2017
@vrann
Copy link
Contributor

vrann commented May 24, 2017

@bka appreciate your contribution!

@magento-team
Copy link
Contributor

@bka thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants