Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR-9713 & PR-9711 for Magento 2.1 - Google Analytics fixes when Cookie Restrictions is enabled #10749

Merged
merged 2 commits into from
Sep 12, 2017

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Sep 2, 2017

cherry picked from commits:

Description

I also took over the reformatting of that line introduced in 391bf42

Fixed Issues (if relevant)

  1. Google Universal Analytics does not track when Cookie Restriction is enabled  #5596: Google Universal Analytics does not track when Cookie Restriction is enabled
  2. Google Analytics Tracking Code cached by Varnish if Cookie Restriction Settings are active #6441: Google Analytics Tracking Code cached by Varnish if Cookie Restriction Settings are active
  3. Cookie Restriction Mode Overlay is cached by Varnish #6455: Cookie Restriction Mode Overlay is cached by Varnish

@bka: do you recommend to also include #9711 in Magento 2.1, it seems like these two PR's are related?
I only backported #9713 for now, because it fixed a specific issue in our case, we didn't need #9711 to fix our issue (we aren't using Varnish, that might explain it), but it might make sense to include both of these in Magento 2.1?

Update: added backport for PR #9711 and updated the issues list above with more issues involved with these fixes

@ishakhsuvarov
Copy link
Contributor

@hostep I've been testing #9711 and #9713 and they seem to be pretty related (as far as I remember I was only able to succeed with testing by applying both together). I'm pretty sure #9711 not only relates to Varnish but to built-in page cache as well.

…lowSaveCookie condition in notice.phtml to fix varnish caching issue magento#6455

(cherry picked from commit 058f287)
@hostep
Copy link
Contributor Author

hostep commented Sep 2, 2017

@ishakhsuvarov: thanks for the very fast review and test!

I added #9711 as a new commit to this PR.

@ishakhsuvarov
Copy link
Contributor

@hostep Haven't tested this PR yet, just sharing my experience from previous testing.
Thanks for the update.

@hostep hostep changed the title Backport PR-9713 for Magento 2.1 - stringify cookie value to fix #5596 Backport PR-9713 & PR-9711 for Magento 2.1 - Google Analytics fixes when Cookie Restrictions is enabled Sep 2, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Sep 4, 2017
@magento-team magento-team merged commit 7a611cc into magento:2.1-develop Sep 12, 2017
magento-team pushed a commit that referenced this pull request Sep 12, 2017
[EngCom] Public Pull Requests - 2.1
 - MAGETWO-72254: Backport PR-9713 for Magento 2.1 - stringify cookie value to fix #5596 #10749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants