Issue #7988 Typo changed also added comments for each index, getters and setters. #9484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm not sure comments add much value here. Comments usually don't. I'd rather you take them out. What happens if the logic changes and the values are not taken from local storage? You'd have to update the comments, too. Suddently, you have two things to maintain. |
okorshenko
changed the title
okorshenko
suggested changes
May 3, 2017
| 'selectedBillingAddress': null, | ||
| 'billingAddressFormData': null, | ||
| 'newCustomerBillingAddress': null | ||
| 'selectedShippingAddress': null, // Selected shipping address pullled from local storage (Persistence) |
There was a problem hiding this comment.
- remove space between // and Selected (fix all cases)
- replace local storage (Persistence) and local storage --> persistence storage
There was a problem hiding this comment.
Updated in my new commit
| }; | ||
| saveData(checkoutData); | ||
| } | ||
|
|
||
| return { | ||
| /** | ||
| * Setting the selected shipping address pulled from local storage |
There was a problem hiding this comment.
add . at the end of the comment. (all cases)
…checkoutData index
okorshenko
approved these changes
May 3, 2017
|
If you're going to do it, at least fix the |
|
Hi @arshadpkm |
|
@ishakhsuvarov Fixed merge conflicts |
magento-team
pushed a commit
that referenced
this pull request
Jun 13, 2017
…index, getters and setters. #9484
magento-team
pushed a commit
that referenced
this pull request
Jun 13, 2017
…index, getters and setters. #9484 - fixed code style issue
magento-team
pushed a commit
that referenced
this pull request
Jun 13, 2017
…index, getters and setters. #9484 - fixed code style issue
magento-team
pushed a commit
that referenced
this pull request
Jun 13, 2017
…index, getters and setters. #9484 - fixed merge conflict
magento-team
pushed a commit
that referenced
this pull request
Jun 13, 2017
…index, getters and setters. #9484
|
Hi @arshadpkm thank you for your contribution. Your Pull Request has been merged. |
AntonEvers
pushed a commit
to AntonEvers/magento2
that referenced
this pull request
Jun 14, 2017
…-9924 * upstream/develop: (60 commits) Fix typo in comment Move prefix and suffix default values to a new PR MAGETWO-68877: Issue magento#7988 Typo changed also added comments for each index, getters and setters. magento#9484 Revert "MAGETWO-69728: Fixes layered navigation options being cached using the wrong store id. magento#9873" MAGETWO-67500: setup:di:compile returns exit code 0 if errors are found magento#7780 Fix prefix, middle name and suffix were not prefilled in the checkout add middle name to checkout address html templates magento#8878 Using Command output as message which actually provides more information for debugging than just the path Handling CLI error as a failure when validating composer.json file MAGETWO-69805: Return array of blocks as items instead of array of arrays magento#9157 MAGETWO-69666: Return array of pages as items instead of array of arrays magento#9823 MAGETWO-69723: Email to a Friend feature magento#9824 MAGETWO-69539: PHP "soap" extension is not declared in composer.json but can be used by Magento modules MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories MAGETWO-63054: [Catalog] MSRP field is not displayed for bundle products with fixed price MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories ...
AntonEvers
pushed a commit
to AntonEvers/magento2
that referenced
this pull request
Jun 14, 2017
* develop: (60 commits) Fix typo in comment Move prefix and suffix default values to a new PR MAGETWO-68877: Issue magento#7988 Typo changed also added comments for each index, getters and setters. magento#9484 Revert "MAGETWO-69728: Fixes layered navigation options being cached using the wrong store id. magento#9873" MAGETWO-67500: setup:di:compile returns exit code 0 if errors are found magento#7780 Fix prefix, middle name and suffix were not prefilled in the checkout add middle name to checkout address html templates magento#8878 Using Command output as message which actually provides more information for debugging than just the path Handling CLI error as a failure when validating composer.json file MAGETWO-69805: Return array of blocks as items instead of array of arrays magento#9157 MAGETWO-69666: Return array of pages as items instead of array of arrays magento#9823 MAGETWO-69723: Email to a Friend feature magento#9824 MAGETWO-69539: PHP "soap" extension is not declared in composer.json but can be used by Magento modules MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories MAGETWO-63054: [Catalog] MSRP field is not displayed for bundle products with fixed price MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories MAGETWO-67087: Saving category deletes url-rewrites for products in anchor categories ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #7988 Typo changed also added comments for each index, getters and setters.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist