setup:di:compile returns exit code 0 if errors are found

[pivulic]

The problem

As a follow up to #3060 and #3189, running bin/magento setup:di:compile doesn't always return a non-zero exit code.

Steps to reproduce

1. Cause an Incorrect dependency error.
2. Run setup:di:compile
3. Check exit code echo $?

Expected result

Since there are Errors during compilation, the exit code should not be 0

Actual result - before this PR

Exit code was 0, since we never entered the catch (OperationException $e) in Magento\Setup\Console\Command\DiCompileCommand::execute()

See screenshot: http://www.vaimo.com/snaps/pablo.ivulic/exit-code-0-not-ok.png

Actual result - after this PR

Exit code is now 1.

[antonkril]

Log writer is incorrect place to throw this exception: nothing went wrong in log writer. Please fix it on command level.

[vrann]

@pivulic Thank you for contribution. I see there are outstanding comments from the previous reviewers, is there any chance you can fix them?

[pivulic]

I'm not quite sure where to exactly fix it. If you know where to fix it on the command level, could maybe you do it?

[vrann]

@pivulic the comment meant to say to move the exception one level up, to the code which invokes error log writer.

The best place as I see would be in the \Magento\Setup\Module\Di\Code\Reader\Decorator\Interceptions::getList, just before $this->log->report();, you can add the code to throw the exception for anything in the $_errorEntries

[pivulic]

@vrann, do you mean in https://github.com/magento/magento2/blob/2.1.5/setup/src/Magento/Setup/Module/Di/Code/Reader/Decorator/Interceptions.php#L85? I can't find the $_errorEntries variable there.

Did you mean something like this:

public function getList($path)
{
    ...
    ...
    ...

    if ($_errorEntries) {
        throw new \Magento\Framework\Validator\Exception(__('Error during compilation'));
    }

    $this->log->report();

    return $nameList;
}

[vrann]

@pivulic sorry taking for the long time to respond. Yes, I mean this:

    public function report()
    {
        $this->_successWriter->write($this->_successEntries);
        $this->_errorWriter->write($this->_errorEntries);
        if (count($this->_errorEntries) > 0) {
              throw new \Magento\Framework\Validator\Exception(__('Error durring compilation'));
        } 
    }

[vrann]

@pivulic please let me know if you need any help with this

[pivulic]

@vrann, does it look better now?

[vrann]

@pivulic looks good

[pivulic]

Can we merge it? :)