Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed coding standard violations in the Framework\Module namespace #9302

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Fixed coding standard violations in the Framework\Module namespace #9302

merged 1 commit into from
Apr 19, 2017

Conversation

dverkade
Copy link
Member

@dverkade dverkade commented Apr 18, 2017

Fixed coding standard violation in the Framework\Module namespace, so that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes:

  • Removed the @codingStandardsIgnoreFile from the head of the file.
  • Fixed line length
  • Changed is_null to === null comparison

… that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes:

- Removed the @codingStandardsIgnoreFile from the head of the file.
- Fixed line length
- Changed is_null to === null comparison
@dverkade dverkade changed the title Fixed coding standard violations in the Framework\Modue namespace Fixed coding standard violations in the Framework\Module namespace Apr 18, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Apr 19, 2017
@ishakhsuvarov ishakhsuvarov added this to the April 2017 milestone Apr 19, 2017
@magento-team magento-team merged commit 5272c37 into magento:develop Apr 19, 2017
magento-team pushed a commit that referenced this pull request Apr 19, 2017
@magento-team
Copy link
Contributor

@dverkade thank you for your contribution to Magento 2 project

@dverkade dverkade deleted the Fix_coding_standard_in_Framework-Module branch June 22, 2018 14:55
magento-devops-reposync-svc pushed a commit that referenced this pull request Oct 30, 2024
[Support Tier-4 chittima] 14-10-2024 Regular delivery of bugfixes and improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants