MAGETWO-67556: Fixed coding standard violations in the Framework\Modu…

…le namespace #9302
magento · Apr 19, 2017 · 6893626 · 6893626
2 parents 43b12f0 + 91d822e
commit 6893626
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/internal/Magento/Framework/Module/ModuleResource.php b/lib/internal/Magento/Framework/Module/ModuleResource.php
@@ -4,14 +4,14 @@
  * See COPYING.txt for license details.
  */
 
-// @codingStandardsIgnoreFile
-
 namespace Magento\Framework\Module;
 
+use \Magento\Framework\Model\ResourceModel\Db\AbstractDb;
+
 /**
  * Resource Model
  */
-class ModuleResource extends \Magento\Framework\Model\ResourceModel\Db\AbstractDb implements \Magento\Framework\Module\ResourceInterface
+class ModuleResource extends AbstractDb implements ResourceInterface
 {
     /**
      * Database versions
@@ -49,7 +49,9 @@ protected function _construct()
      */
     protected function _loadVersion($needType)
     {
-        if ($needType == 'db' && is_null(self::$schemaVersions) || $needType == 'data' && is_null(self::$dataVersions)) {
+        if ($needType == 'db' && self::$schemaVersions === null ||
+            $needType == 'data' && self::$dataVersions === null
+        ) {
             self::$schemaVersions = [];
             // Db version column always exists
             self::$dataVersions = null;
@@ -61,7 +63,7 @@ protected function _loadVersion($needType)
                 foreach ($rowset as $row) {
                     self::$schemaVersions[$row['module']] = $row['schema_version'];
                     if (array_key_exists('data_version', $row)) {
-                        if (is_null(self::$dataVersions)) {
+                        if (self::$dataVersions === null) {
                             self::$dataVersions = [];
                         }
                         self::$dataVersions[$row['module']] = $row['data_version'];

diff --git a/lib/internal/Magento/Framework/Module/Setup/MigrationFactory.php b/lib/internal/Magento/Framework/Module/Setup/MigrationFactory.php
@@ -4,8 +4,6 @@
  * See COPYING.txt for license details.
  */
 
-// @codingStandardsIgnoreFile
-
 namespace Magento\Framework\Module\Setup;
 
 /**