Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Framework coding standard compliant #7166

Closed
wants to merge 96 commits into from
Closed

Make Framework coding standard compliant #7166

wants to merge 96 commits into from

Commits on Oct 20, 2016

  1. - Removed the @codingStandardsIgnoreFile in every php file in the fra…

    …mework.
    
    - Made a couple of changes to some files already
    - This will probably break the build. Let's see if I can fix all the issues
    dverkade committed Oct 20, 2016
    Configuration menu
    Copy the full SHA
    7d7c327 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2016

  1. Configuration menu
    Copy the full SHA
    24e6743 View commit details
    Browse the repository at this point in the history
  2. - Changed sample repository because it gave errors on the double slas…

    …h in the codesniffer.
    dverkade committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    8fe8e79 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e3f3688 View commit details
    Browse the repository at this point in the history
  4. Fixed coding standard error: Line exceeds maximum limit of 120 charac…

    …ters; contains 123 characters
    dverkade committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    ab2e947 View commit details
    Browse the repository at this point in the history
  5. Fixed coding standard error: Only one argument is allowed per line in…

    … a multi-line function call
    dverkade committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    d71e431 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    11d271a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    10131b4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7427576 View commit details
    Browse the repository at this point in the history
  9. Fixed coding standard error: Line exceeds maximum limit of 120 charac…

    …ters; contains 134 characters
    dverkade committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    b6238d2 View commit details
    Browse the repository at this point in the history
  10. Fixed coding standard error: Line exceeds maximum limit of 120 charac…

    …ters; contains 125 characters
    dverkade committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    7dd2548 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2016

  1. Fixed coding standard violation: Line exceeds maximum limit of 120 ch…

    …aracters; contains 121 characters
    dverkade committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    08db17d View commit details
    Browse the repository at this point in the history
  2. Fixed coding standard error: Line exceeds maximum limit of 120 charac…

    …ters; contains 128 characters
    dverkade committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    8ec994a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    efa9c54 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0538366 View commit details
    Browse the repository at this point in the history
  5. Fixed coding standard violation: Code must not contain multiple empty…

    … lines in a row; found 2 empty lines
    dverkade committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    2880731 View commit details
    Browse the repository at this point in the history
  6. Fixed coding standard violations:

    - Code must not contain multiple empty lines in a row; found 2 empty lines
    - Line exceeds maximum limit of 120 characters; contains 124 characters
    dverkade committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    bc0d31a View commit details
    Browse the repository at this point in the history
  7. Fixed coding standard violation: Line indented incorrectly; expected …

    …at least 8 spaces, found 0
    dverkade committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    af5343d View commit details
    Browse the repository at this point in the history
  8. Fixed coding standard violations:

    - Missing function doc comment
    - Code must not contain multiple empty lines in a row; found 2 empty lines
    dverkade committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    809a685 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    824561e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    aa821a2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    21af3cb View commit details
    Browse the repository at this point in the history
  12. Fixed coding standard violations:

    - Variable "value_hrs" is not in valid camel caps format
    - Variable "value_min" is not in valid camel caps format
    - Variable "value_sec" is not in valid camel caps format
    dverkade committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    3f16a5d View commit details
    Browse the repository at this point in the history
  13. Fixed coding standard violation: Only one argument is allowed per lin…

    …e in a multi-line function call
    dverkade committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    659ab34 View commit details
    Browse the repository at this point in the history
  14. Fixed coding standard violations:

    - Code must not contain multiple empty lines in a row; found 2 empty lines
    - Missing parameter name at position 1
    dverkade committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    68519e0 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    4703ad2 View commit details
    Browse the repository at this point in the history
  16. Fixed coding violations:

    - Variable "no_errors" is not in valid camel caps format
    - Variable "dir_item" is not in valid camel caps format
    - is_null must be avoided. Use strict comparison instead.
    dverkade committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    487bac3 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2016

  1. Fixed coding standard violations:

    - Line exceeds maximum limit of 120 characters; contains 121 characters
    - is_null must be avoided. Use strict comparison instead.
    dverkade committed Oct 26, 2016
    Configuration menu
    Copy the full SHA
    abf7856 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e8b1acb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    210afe6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3fdb625 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2016

  1. - Fixed coding standard error Use ::class notation instead.

    - Fixed coding standard error Empty line missed
    - Fixed coding standard error Line indented incorrectly; expected at least 8 spaces, found 0
    dverkade committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    9681a73 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d87dbd View commit details
    Browse the repository at this point in the history
  3. - Fixed coding standard error Line exceeds maximum limit of 120 chara…

    …cters; contains characters
    
    - Fixed coding standard error Code must not contain multiple empty lines in a row; found 2 empty lines
    - Fixed coding standard error is_null must be avoided. Use strict comparison instead.
    dverkade committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    482ce96 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    df42723 View commit details
    Browse the repository at this point in the history
  5. Fixed coding standard error: Opening parenthesis of a multi-line func…

    …tion call must be the last content on the line
    dverkade committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    7d9ccb6 View commit details
    Browse the repository at this point in the history
  6. - Fixed coding standard error: Expected 1 space(s) before asterisk; 0…

    … found
    
    - Fixed coding standard error: Line exceeds maximum limit of 120 characters;
    - Fixed coding standard error: Missing parameter name at position 1
    dverkade committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    8c6bcc7 View commit details
    Browse the repository at this point in the history
  7. - Fixed coding standard error: Variable "line_number" is not in valid…

    … camel caps format
    
    - Fixed coding standard error: Line exceeds maximum limit of 120 characters;
    - Fixed coding standard error: Variable "tmp_value" is not in valid camel caps format
    - Fixed coding standard error: Variable "tmp_line" is not in valid camel caps format
    dverkade committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    9933c46 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2016

  1. Resolved merge conflicts

    dverkade committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    7b2dc30 View commit details
    Browse the repository at this point in the history
  2. Fixed coding standard errors:

    - Line exceeds maximum limit of 120 characters;
    - is_null must be avoided. Use strict comparison instead.
    dverkade committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    a9be415 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c1935f1 View commit details
    Browse the repository at this point in the history
  4. - Changed type, removed extra space from comment

    - Fixed coding standard error: Line exceeds maximum limit of 120 characters;
    dverkade committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    8b937d9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bf2ef25 View commit details
    Browse the repository at this point in the history
  6. Trimmed whitespaces at the end of the line in order to fix coding sta…

    …ndards: Line exceeds maximum limit of 120 characters
    dverkade committed Nov 19, 2016
    Configuration menu
    Copy the full SHA
    44c4b07 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2016

  1. Corrected coding standard errors:

    -  Multi-line function call not indented correctly
    - Line exceeds maximum limit of 120 characters
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    6ea3f9a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4ac5bb1 View commit details
    Browse the repository at this point in the history
  3. Fixed coding standard errors:

    - Line exceeds maximum limit of 120 characters
    - Code must not contain multiple empty lines in a row
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    705375e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ee131c9 View commit details
    Browse the repository at this point in the history
  5. Fixed coding standard errors:

    - is_null must be avoided. Use strict comparison instead
    - Line exceeds maximum limit of 120 characters
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    e27f3e3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c061f65 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e7e4213 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    281c74c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    fa476ac View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    763a2c8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d9da868 View commit details
    Browse the repository at this point in the history
  12. Fixed coding standard errors:

    - Line exceeds maximum limit of 120 characters
    - Surpressed: Avoid unused parameters such as '$skipRoot'.
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    a422e7d View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    87869d2 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0a11455 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    f062a2a View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    b36b01b View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    1f914d5 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    4884f47 View commit details
    Browse the repository at this point in the history
  19. Fixed coding standard violations:

    - Changed position of the @codingStandardsIgnoreEnd
    - Fixed Visibility must be declared on property
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    2727cfa View commit details
    Browse the repository at this point in the history
  20. - Changed Code Sniffer rule set in order to exclude all _files for cl…

    …ass declaration coding standard errors. These files should be exclused since they are mostly stub classes which are used for unit testing. Creating seperate files for them should not be necessary.
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    304ace3 View commit details
    Browse the repository at this point in the history
  21. Fixed coding standard violations:

    - Ignored line exceeds maximum limit of 120 characters
    - Fixed Empty line missed
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    119254e View commit details
    Browse the repository at this point in the history
  22. Fixed coding standard violations:

    -  Interface should have name that ends with "Interface" suffix.
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    dd5164f View commit details
    Browse the repository at this point in the history
  23. Fixed coding standard violations:

    -  Interface should have name that ends with "Interface" suffix.
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    f22f978 View commit details
    Browse the repository at this point in the history
  24. Removed dubble class names

    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    f8f68f6 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    0992f88 View commit details
    Browse the repository at this point in the history
  26. Fixed coding standard violations:

    - Expected 5 space(s) before asterisk; 0 found
    - Line indented incorrectly; expected at least 8 spaces, found 0
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    fb4abaf View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    8824b29 View commit details
    Browse the repository at this point in the history
  28. - Combined testCodeStylePsr2() with the testCodeStyle() function.

    - Core Magento team mentioned to combine these 2 functions in the comments.
    - Excluded _files/* from the PSR2 standards because these are stub files for tests and multiple classes per file throws PSR2 errors for these files.
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    3fbdf2c View commit details
    Browse the repository at this point in the history
  29. Merge branch 'Combine_PSR2_code_sniffer_test_with_code_style_test' in…

    …to Framework_adhiring_coding_standards
    
    Conflicts:
    	dev/tests/static/testsuite/Magento/Test/Php/_files/phpcs/ruleset.xml
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    43c2e57 View commit details
    Browse the repository at this point in the history
  30. Changed the exclude pattern to be located under the ruleset node inst…

    …ead of the rule (which is not working according to PHP Codesniffer documentation).
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    77dd5d5 View commit details
    Browse the repository at this point in the history
  31. Merge branch 'Combine_PSR2_code_sniffer_test_with_code_style_test' in…

    …to Framework_adhiring_coding_standards
    dverkade committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    c7898aa View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2016

  1. Fixed coding standard error:

    - Line exceeds maximum limit of 120 characters
    - Expected message can be a partial of the complete exception string. Changed this in order to be below 120 chars on the line.
    dverkade committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    1ac6ed4 View commit details
    Browse the repository at this point in the history
  2. Fixed coding standard error:

    - Fixed empty line typo
    - Added codingstandardignore to comment which could not become 120 chars or less.
    dverkade committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    1772739 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4293628 View commit details
    Browse the repository at this point in the history
  4. Fixed coding standard error:

    - Method name "Request::SslOffloadHeader" is not in camel caps format
    dverkade committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    0e68759 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f5317d2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6390a7d View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2016

  1. Configuration menu
    Copy the full SHA
    6cb43fc View commit details
    Browse the repository at this point in the history
  2. Revert "Print the codesniffer version number to check which version i…

    …s being used by the builds"
    
    This reverts commit 6cb43fc.
    dverkade committed Nov 24, 2016
    Configuration menu
    Copy the full SHA
    1c0def9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2f2351b View commit details
    Browse the repository at this point in the history
  4. Revert "Checking PHP Codesniffer versions"

    This reverts commit 2f2351b.
    dverkade committed Nov 24, 2016
    Configuration menu
    Copy the full SHA
    1d1a5b4 View commit details
    Browse the repository at this point in the history
  5. @codingStandardIgnoreLine doesn't work correctly in docblocks. So com…

    …mented out the complete sections with the @codingStandardsIgnoreStart and @codingStandardsIgnoreEnd annotations.
    dverkade committed Nov 24, 2016
    Configuration menu
    Copy the full SHA
    1b6a747 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c3be4cd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    091f5e9 View commit details
    Browse the repository at this point in the history
  8. Revert "Enabling static tests for PHP 7.0 images."

    This reverts commit 091f5e9.
    dverkade committed Nov 24, 2016
    Configuration menu
    Copy the full SHA
    40f9729 View commit details
    Browse the repository at this point in the history
  9. Travis should run the static tests against PHP 7

    Travis should be changed so that static tests will be runned against PHP 7 as well. 
    
    See for instance this build: https://travis-ci.org/magento/magento2/builds/178637640
    Static tests pass against PHP 7 but fail against PHP 5.6. So there is difference between the two versions and we should build en pass static test for both PHP versions.
    dverkade authored Nov 24, 2016
    Configuration menu
    Copy the full SHA
    76eed97 View commit details
    Browse the repository at this point in the history
  10. Merge branch 'patch-16' of https://github.com/dverkade/magento2 into …

    …Framework_adhiring_coding_standards
    dverkade committed Nov 24, 2016
    Configuration menu
    Copy the full SHA
    5dd0920 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2016

  1. Fixed coding standard error: Function mysql() has been deprecated

    This is due to codesniffer bug where MySQL class name is processed as a function. So for now ignored coding standards for class definition. Could be changed later on when this bug is fixed in Codesniffer.
    dverkade committed Nov 26, 2016
    Configuration menu
    Copy the full SHA
    17b54a7 View commit details
    Browse the repository at this point in the history
  2. - Changed SevenInterface to use "array()" instead of []. Code generat…

    …ion of Magento generates "array()" so this should be the same.
    
    - Removed extra empty line after interface generating, because and empty line is already present from the methods generating. So only one empty line is between the last method and class closure instead of two.
    dverkade committed Nov 26, 2016
    Configuration menu
    Copy the full SHA
    ac4591c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    582d5c9 View commit details
    Browse the repository at this point in the history
  4. Added a global \ to setting the addTrait and Interfaces because the :…

    …:class does give you a fully qualified class name, but not with the \ at the beginning. This resultated in the class not starting from the global namespace and breaking the build.
    dverkade committed Nov 26, 2016
    Configuration menu
    Copy the full SHA
    9fe4d39 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    40f89f9 View commit details
    Browse the repository at this point in the history