-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Framework coding standard compliant #7166
Make Framework coding standard compliant #7166
Commits on Oct 20, 2016
-
- Removed the @codingStandardsIgnoreFile in every php file in the fra…
…mework. - Made a couple of changes to some files already - This will probably break the build. Let's see if I can fix all the issues
Configuration menu - View commit details
-
Copy full SHA for 7d7c327 - Browse repository at this point
Copy the full SHA 7d7c327View commit details
Commits on Oct 24, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 24e6743 - Browse repository at this point
Copy the full SHA 24e6743View commit details -
- Changed sample repository because it gave errors on the double slas…
…h in the codesniffer.
Configuration menu - View commit details
-
Copy full SHA for 8fe8e79 - Browse repository at this point
Copy the full SHA 8fe8e79View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3f3688 - Browse repository at this point
Copy the full SHA e3f3688View commit details -
Fixed coding standard error: Line exceeds maximum limit of 120 charac…
…ters; contains 123 characters
Configuration menu - View commit details
-
Copy full SHA for ab2e947 - Browse repository at this point
Copy the full SHA ab2e947View commit details -
Fixed coding standard error: Only one argument is allowed per line in…
… a multi-line function call
Configuration menu - View commit details
-
Copy full SHA for d71e431 - Browse repository at this point
Copy the full SHA d71e431View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11d271a - Browse repository at this point
Copy the full SHA 11d271aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10131b4 - Browse repository at this point
Copy the full SHA 10131b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7427576 - Browse repository at this point
Copy the full SHA 7427576View commit details -
Fixed coding standard error: Line exceeds maximum limit of 120 charac…
…ters; contains 134 characters
Configuration menu - View commit details
-
Copy full SHA for b6238d2 - Browse repository at this point
Copy the full SHA b6238d2View commit details -
Fixed coding standard error: Line exceeds maximum limit of 120 charac…
…ters; contains 125 characters
Configuration menu - View commit details
-
Copy full SHA for 7dd2548 - Browse repository at this point
Copy the full SHA 7dd2548View commit details
Commits on Oct 25, 2016
-
Fixed coding standard violation: Line exceeds maximum limit of 120 ch…
…aracters; contains 121 characters
Configuration menu - View commit details
-
Copy full SHA for 08db17d - Browse repository at this point
Copy the full SHA 08db17dView commit details -
Fixed coding standard error: Line exceeds maximum limit of 120 charac…
…ters; contains 128 characters
Configuration menu - View commit details
-
Copy full SHA for 8ec994a - Browse repository at this point
Copy the full SHA 8ec994aView commit details -
Fixed coding standard violation: Var type missing for @var tag in var…
…iable comment
Configuration menu - View commit details
-
Copy full SHA for efa9c54 - Browse repository at this point
Copy the full SHA efa9c54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0538366 - Browse repository at this point
Copy the full SHA 0538366View commit details -
Fixed coding standard violation: Code must not contain multiple empty…
… lines in a row; found 2 empty lines
Configuration menu - View commit details
-
Copy full SHA for 2880731 - Browse repository at this point
Copy the full SHA 2880731View commit details -
Fixed coding standard violations:
- Code must not contain multiple empty lines in a row; found 2 empty lines - Line exceeds maximum limit of 120 characters; contains 124 characters
Configuration menu - View commit details
-
Copy full SHA for bc0d31a - Browse repository at this point
Copy the full SHA bc0d31aView commit details -
Fixed coding standard violation: Line indented incorrectly; expected …
…at least 8 spaces, found 0
Configuration menu - View commit details
-
Copy full SHA for af5343d - Browse repository at this point
Copy the full SHA af5343dView commit details -
Fixed coding standard violations:
- Missing function doc comment - Code must not contain multiple empty lines in a row; found 2 empty lines
Configuration menu - View commit details
-
Copy full SHA for 809a685 - Browse repository at this point
Copy the full SHA 809a685View commit details -
Configuration menu - View commit details
-
Copy full SHA for 824561e - Browse repository at this point
Copy the full SHA 824561eView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa821a2 - Browse repository at this point
Copy the full SHA aa821a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21af3cb - Browse repository at this point
Copy the full SHA 21af3cbView commit details -
Fixed coding standard violations:
- Variable "value_hrs" is not in valid camel caps format - Variable "value_min" is not in valid camel caps format - Variable "value_sec" is not in valid camel caps format
Configuration menu - View commit details
-
Copy full SHA for 3f16a5d - Browse repository at this point
Copy the full SHA 3f16a5dView commit details -
Fixed coding standard violation: Only one argument is allowed per lin…
…e in a multi-line function call
Configuration menu - View commit details
-
Copy full SHA for 659ab34 - Browse repository at this point
Copy the full SHA 659ab34View commit details -
Fixed coding standard violations:
- Code must not contain multiple empty lines in a row; found 2 empty lines - Missing parameter name at position 1
Configuration menu - View commit details
-
Copy full SHA for 68519e0 - Browse repository at this point
Copy the full SHA 68519e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4703ad2 - Browse repository at this point
Copy the full SHA 4703ad2View commit details -
- Variable "no_errors" is not in valid camel caps format - Variable "dir_item" is not in valid camel caps format - is_null must be avoided. Use strict comparison instead.
Configuration menu - View commit details
-
Copy full SHA for 487bac3 - Browse repository at this point
Copy the full SHA 487bac3View commit details
Commits on Oct 26, 2016
-
Fixed coding standard violations:
- Line exceeds maximum limit of 120 characters; contains 121 characters - is_null must be avoided. Use strict comparison instead.
Configuration menu - View commit details
-
Copy full SHA for abf7856 - Browse repository at this point
Copy the full SHA abf7856View commit details -
Fixed coding standard violation: is_null must be avoided. Use strict …
…comparison instead.
Configuration menu - View commit details
-
Copy full SHA for e8b1acb - Browse repository at this point
Copy the full SHA e8b1acbView commit details -
Fixed coding standard violation: is_null must be avoided. Use strict …
…comparison instead.
Configuration menu - View commit details
-
Copy full SHA for 210afe6 - Browse repository at this point
Copy the full SHA 210afe6View commit details -
Fixed coding standard violations: is_null must be avoided. Use strict…
… comparison instead.
Configuration menu - View commit details
-
Copy full SHA for 3fdb625 - Browse repository at this point
Copy the full SHA 3fdb625View commit details
Commits on Nov 18, 2016
-
- Fixed coding standard error Use ::class notation instead.
- Fixed coding standard error Empty line missed - Fixed coding standard error Line indented incorrectly; expected at least 8 spaces, found 0
Configuration menu - View commit details
-
Copy full SHA for 9681a73 - Browse repository at this point
Copy the full SHA 9681a73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d87dbd - Browse repository at this point
Copy the full SHA 5d87dbdView commit details -
- Fixed coding standard error Line exceeds maximum limit of 120 chara…
…cters; contains characters - Fixed coding standard error Code must not contain multiple empty lines in a row; found 2 empty lines - Fixed coding standard error is_null must be avoided. Use strict comparison instead.
Configuration menu - View commit details
-
Copy full SHA for 482ce96 - Browse repository at this point
Copy the full SHA 482ce96View commit details -
Configuration menu - View commit details
-
Copy full SHA for df42723 - Browse repository at this point
Copy the full SHA df42723View commit details -
Fixed coding standard error: Opening parenthesis of a multi-line func…
…tion call must be the last content on the line
Configuration menu - View commit details
-
Copy full SHA for 7d9ccb6 - Browse repository at this point
Copy the full SHA 7d9ccb6View commit details -
- Fixed coding standard error: Expected 1 space(s) before asterisk; 0…
… found - Fixed coding standard error: Line exceeds maximum limit of 120 characters; - Fixed coding standard error: Missing parameter name at position 1
Configuration menu - View commit details
-
Copy full SHA for 8c6bcc7 - Browse repository at this point
Copy the full SHA 8c6bcc7View commit details -
- Fixed coding standard error: Variable "line_number" is not in valid…
… camel caps format - Fixed coding standard error: Line exceeds maximum limit of 120 characters; - Fixed coding standard error: Variable "tmp_value" is not in valid camel caps format - Fixed coding standard error: Variable "tmp_line" is not in valid camel caps format
Configuration menu - View commit details
-
Copy full SHA for 9933c46 - Browse repository at this point
Copy the full SHA 9933c46View commit details
Commits on Nov 19, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 7b2dc30 - Browse repository at this point
Copy the full SHA 7b2dc30View commit details -
- Line exceeds maximum limit of 120 characters; - is_null must be avoided. Use strict comparison instead.
Configuration menu - View commit details
-
Copy full SHA for a9be415 - Browse repository at this point
Copy the full SHA a9be415View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1935f1 - Browse repository at this point
Copy the full SHA c1935f1View commit details -
- Changed type, removed extra space from comment
- Fixed coding standard error: Line exceeds maximum limit of 120 characters;
Configuration menu - View commit details
-
Copy full SHA for 8b937d9 - Browse repository at this point
Copy the full SHA 8b937d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf2ef25 - Browse repository at this point
Copy the full SHA bf2ef25View commit details -
Trimmed whitespaces at the end of the line in order to fix coding sta…
…ndards: Line exceeds maximum limit of 120 characters
Configuration menu - View commit details
-
Copy full SHA for 44c4b07 - Browse repository at this point
Copy the full SHA 44c4b07View commit details
Commits on Nov 20, 2016
-
Corrected coding standard errors:
- Multi-line function call not indented correctly - Line exceeds maximum limit of 120 characters
Configuration menu - View commit details
-
Copy full SHA for 6ea3f9a - Browse repository at this point
Copy the full SHA 6ea3f9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ac5bb1 - Browse repository at this point
Copy the full SHA 4ac5bb1View commit details -
- Line exceeds maximum limit of 120 characters - Code must not contain multiple empty lines in a row
Configuration menu - View commit details
-
Copy full SHA for 705375e - Browse repository at this point
Copy the full SHA 705375eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee131c9 - Browse repository at this point
Copy the full SHA ee131c9View commit details -
- is_null must be avoided. Use strict comparison instead - Line exceeds maximum limit of 120 characters
Configuration menu - View commit details
-
Copy full SHA for e27f3e3 - Browse repository at this point
Copy the full SHA e27f3e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c061f65 - Browse repository at this point
Copy the full SHA c061f65View commit details -
Fixed coding standard error: There must be one blank line after the n…
…amespace declaration
Configuration menu - View commit details
-
Copy full SHA for e7e4213 - Browse repository at this point
Copy the full SHA e7e4213View commit details -
Configuration menu - View commit details
-
Copy full SHA for 281c74c - Browse repository at this point
Copy the full SHA 281c74cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa476ac - Browse repository at this point
Copy the full SHA fa476acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 763a2c8 - Browse repository at this point
Copy the full SHA 763a2c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9da868 - Browse repository at this point
Copy the full SHA d9da868View commit details -
- Line exceeds maximum limit of 120 characters - Surpressed: Avoid unused parameters such as '$skipRoot'.
Configuration menu - View commit details
-
Copy full SHA for a422e7d - Browse repository at this point
Copy the full SHA a422e7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87869d2 - Browse repository at this point
Copy the full SHA 87869d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a11455 - Browse repository at this point
Copy the full SHA 0a11455View commit details -
Configuration menu - View commit details
-
Copy full SHA for f062a2a - Browse repository at this point
Copy the full SHA f062a2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b36b01b - Browse repository at this point
Copy the full SHA b36b01bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f914d5 - Browse repository at this point
Copy the full SHA 1f914d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4884f47 - Browse repository at this point
Copy the full SHA 4884f47View commit details -
Fixed coding standard violations:
- Changed position of the @codingStandardsIgnoreEnd - Fixed Visibility must be declared on property
Configuration menu - View commit details
-
Copy full SHA for 2727cfa - Browse repository at this point
Copy the full SHA 2727cfaView commit details -
- Changed Code Sniffer rule set in order to exclude all _files for cl…
…ass declaration coding standard errors. These files should be exclused since they are mostly stub classes which are used for unit testing. Creating seperate files for them should not be necessary.
Configuration menu - View commit details
-
Copy full SHA for 304ace3 - Browse repository at this point
Copy the full SHA 304ace3View commit details -
Fixed coding standard violations:
- Ignored line exceeds maximum limit of 120 characters - Fixed Empty line missed
Configuration menu - View commit details
-
Copy full SHA for 119254e - Browse repository at this point
Copy the full SHA 119254eView commit details -
Fixed coding standard violations:
- Interface should have name that ends with "Interface" suffix.
Configuration menu - View commit details
-
Copy full SHA for dd5164f - Browse repository at this point
Copy the full SHA dd5164fView commit details -
Fixed coding standard violations:
- Interface should have name that ends with "Interface" suffix.
Configuration menu - View commit details
-
Copy full SHA for f22f978 - Browse repository at this point
Copy the full SHA f22f978View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8f68f6 - Browse repository at this point
Copy the full SHA f8f68f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0992f88 - Browse repository at this point
Copy the full SHA 0992f88View commit details -
Fixed coding standard violations:
- Expected 5 space(s) before asterisk; 0 found - Line indented incorrectly; expected at least 8 spaces, found 0
Configuration menu - View commit details
-
Copy full SHA for fb4abaf - Browse repository at this point
Copy the full SHA fb4abafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8824b29 - Browse repository at this point
Copy the full SHA 8824b29View commit details -
- Combined testCodeStylePsr2() with the testCodeStyle() function.
- Core Magento team mentioned to combine these 2 functions in the comments. - Excluded _files/* from the PSR2 standards because these are stub files for tests and multiple classes per file throws PSR2 errors for these files.
Configuration menu - View commit details
-
Copy full SHA for 3fbdf2c - Browse repository at this point
Copy the full SHA 3fbdf2cView commit details -
Merge branch 'Combine_PSR2_code_sniffer_test_with_code_style_test' in…
…to Framework_adhiring_coding_standards Conflicts: dev/tests/static/testsuite/Magento/Test/Php/_files/phpcs/ruleset.xml
Configuration menu - View commit details
-
Copy full SHA for 43c2e57 - Browse repository at this point
Copy the full SHA 43c2e57View commit details -
Changed the exclude pattern to be located under the ruleset node inst…
…ead of the rule (which is not working according to PHP Codesniffer documentation).
Configuration menu - View commit details
-
Copy full SHA for 77dd5d5 - Browse repository at this point
Copy the full SHA 77dd5d5View commit details -
Merge branch 'Combine_PSR2_code_sniffer_test_with_code_style_test' in…
…to Framework_adhiring_coding_standards
Configuration menu - View commit details
-
Copy full SHA for c7898aa - Browse repository at this point
Copy the full SHA c7898aaView commit details
Commits on Nov 22, 2016
-
- Line exceeds maximum limit of 120 characters - Expected message can be a partial of the complete exception string. Changed this in order to be below 120 chars on the line.
Configuration menu - View commit details
-
Copy full SHA for 1ac6ed4 - Browse repository at this point
Copy the full SHA 1ac6ed4View commit details -
- Fixed empty line typo - Added codingstandardignore to comment which could not become 120 chars or less.
Configuration menu - View commit details
-
Copy full SHA for 1772739 - Browse repository at this point
Copy the full SHA 1772739View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4293628 - Browse repository at this point
Copy the full SHA 4293628View commit details -
- Method name "Request::SslOffloadHeader" is not in camel caps format
Configuration menu - View commit details
-
Copy full SHA for 0e68759 - Browse repository at this point
Copy the full SHA 0e68759View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5317d2 - Browse repository at this point
Copy the full SHA f5317d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6390a7d - Browse repository at this point
Copy the full SHA 6390a7dView commit details
Commits on Nov 24, 2016
-
Print the codesniffer version number to check which version is being …
…used by the builds
Configuration menu - View commit details
-
Copy full SHA for 6cb43fc - Browse repository at this point
Copy the full SHA 6cb43fcView commit details -
Revert "Print the codesniffer version number to check which version i…
…s being used by the builds" This reverts commit 6cb43fc.
Configuration menu - View commit details
-
Copy full SHA for 1c0def9 - Browse repository at this point
Copy the full SHA 1c0def9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f2351b - Browse repository at this point
Copy the full SHA 2f2351bView commit details -
Revert "Checking PHP Codesniffer versions"
This reverts commit 2f2351b.
Configuration menu - View commit details
-
Copy full SHA for 1d1a5b4 - Browse repository at this point
Copy the full SHA 1d1a5b4View commit details -
@codingStandardIgnoreLine doesn't work correctly in docblocks. So com…
…mented out the complete sections with the @codingStandardsIgnoreStart and @codingStandardsIgnoreEnd annotations.
Configuration menu - View commit details
-
Copy full SHA for 1b6a747 - Browse repository at this point
Copy the full SHA 1b6a747View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3be4cd - Browse repository at this point
Copy the full SHA c3be4cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 091f5e9 - Browse repository at this point
Copy the full SHA 091f5e9View commit details -
Revert "Enabling static tests for PHP 7.0 images."
This reverts commit 091f5e9.
Configuration menu - View commit details
-
Copy full SHA for 40f9729 - Browse repository at this point
Copy the full SHA 40f9729View commit details -
Travis should run the static tests against PHP 7
Travis should be changed so that static tests will be runned against PHP 7 as well. See for instance this build: https://travis-ci.org/magento/magento2/builds/178637640 Static tests pass against PHP 7 but fail against PHP 5.6. So there is difference between the two versions and we should build en pass static test for both PHP versions.
Configuration menu - View commit details
-
Copy full SHA for 76eed97 - Browse repository at this point
Copy the full SHA 76eed97View commit details -
Merge branch 'patch-16' of https://github.com/dverkade/magento2 into …
…Framework_adhiring_coding_standards
Configuration menu - View commit details
-
Copy full SHA for 5dd0920 - Browse repository at this point
Copy the full SHA 5dd0920View commit details
Commits on Nov 26, 2016
-
Fixed coding standard error: Function mysql() has been deprecated
This is due to codesniffer bug where MySQL class name is processed as a function. So for now ignored coding standards for class definition. Could be changed later on when this bug is fixed in Codesniffer.
Configuration menu - View commit details
-
Copy full SHA for 17b54a7 - Browse repository at this point
Copy the full SHA 17b54a7View commit details -
- Changed SevenInterface to use "array()" instead of []. Code generat…
…ion of Magento generates "array()" so this should be the same. - Removed extra empty line after interface generating, because and empty line is already present from the methods generating. So only one empty line is between the last method and class closure instead of two.
Configuration menu - View commit details
-
Copy full SHA for ac4591c - Browse repository at this point
Copy the full SHA ac4591cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 582d5c9 - Browse repository at this point
Copy the full SHA 582d5c9View commit details -
Added a global \ to setting the addTrait and Interfaces because the :…
…:class does give you a fully qualified class name, but not with the \ at the beginning. This resultated in the class not starting from the global namespace and breaking the build.
Configuration menu - View commit details
-
Copy full SHA for 9fe4d39 - Browse repository at this point
Copy the full SHA 9fe4d39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40f89f9 - Browse repository at this point
Copy the full SHA 40f89f9View commit details