Make Framework coding standard compliant #7166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mework. - Made a couple of changes to some files already - This will probably break the build. Let's see if I can fix all the issues
…h in the codesniffer.
…ters; contains 123 characters
… a multi-line function call
…ters; contains 134 characters
…ters; contains 125 characters
|
This is still a work in progress and I will fix all outstanding issues file by file. |
…aracters; contains 121 characters
…ters; contains 128 characters
… lines in a row; found 2 empty lines
- Code must not contain multiple empty lines in a row; found 2 empty lines - Line exceeds maximum limit of 120 characters; contains 124 characters
…at least 8 spaces, found 0
- Missing function doc comment - Code must not contain multiple empty lines in a row; found 2 empty lines
- Variable "value_hrs" is not in valid camel caps format - Variable "value_min" is not in valid camel caps format - Variable "value_sec" is not in valid camel caps format
…e in a multi-line function call
- Code must not contain multiple empty lines in a row; found 2 empty lines - Missing parameter name at position 1
- Variable "no_errors" is not in valid camel caps format - Variable "dir_item" is not in valid camel caps format - is_null must be avoided. Use strict comparison instead.
- Line exceeds maximum limit of 120 characters; contains 121 characters - is_null must be avoided. Use strict comparison instead.
…comparison instead.
- Method name "Request::SslOffloadHeader" is not in camel caps format
…used by the builds
…s being used by the builds" This reverts commit 6cb43fc.
This reverts commit 2f2351b.
…mented out the complete sections with the @codingStandardsIgnoreStart and @codingStandardsIgnoreEnd annotations.
This reverts commit 091f5e9.
Travis should be changed so that static tests will be runned against PHP 7 as well. See for instance this build: https://travis-ci.org/magento/magento2/builds/178637640 Static tests pass against PHP 7 but fail against PHP 5.6. So there is difference between the two versions and we should build en pass static test for both PHP versions.
…Framework_adhiring_coding_standards
This is due to codesniffer bug where MySQL class name is processed as a function. So for now ignored coding standards for class definition. Could be changed later on when this bug is fixed in Codesniffer.
…ion of Magento generates "array()" so this should be the same. - Removed extra empty line after interface generating, because and empty line is already present from the methods generating. So only one empty line is between the last method and class closure instead of two.
…:class does give you a fully qualified class name, but not with the \ at the beginning. This resultated in the class not starting from the global namespace and breaking the build.
|
This PR is already nearly impossible to process and it's just Framework part. Automated changes must not be mixed with some manual work. I described viable strategy and why it won't work this way here. |
|
Hi @orlangur what do you mean by "Automated changes must not be mixed with some manual work." |
|
@dverkade are you still working on this or we can close this PR? |
|
Hi @okorshenko Is see that many of these issues have been fixed by merging this pull request: 8685 Is that a solution that works best for you guys? |
|
@dverkade seeing update in this PR I wanted to suggest you joining my efforts on making codebase standards compliant :) Here is the detailed plan: #8823 (comment) Let's do the 1. similar to approach I used in 8685:
|
This was referenced Apr 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started work on the Magento Framework to become coding standard compliant.