Removes some code for PHP versions we no longer support.

[hostep]

Description (*)

Found some code in the codebase that no longer makes sense if we only support PHP 8.2 (soon 8.3?) and higher:

• libxml_disable_entity_loader was deprecated in PHP 8.0: https://php.watch/versions/8.0/libxml_disable_entity_loader-deprecation
• always_populate_raw_post_data was removed in PHP 7.0: https://www.php.net/manual/en/migration70.incompatible.php#migration70.incompatible.removed-ini-directives.features

Related Pull Requests

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

1. Check that the changed classes still function like they should function

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Removes some code for PHP versions we no longer support. #39361: Removes some code for PHP versions we no longer support.

Resolved issues:

1. resolves [Issue] Removes some code for PHP versions we no longer support. #39368: Removes some code for PHP versions we no longer support.

[m2-assistant]

Hi @hostep. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[hostep]

@magento run all tests

[Den4ik]

Hey @hostep
Thanks for the PR, it's great update.
✅ All looks ok for me.

[Den4ik]

@magento run Integration Tests

[engcom-Charlie]

Hi @hostep,

Thank you for the contribution!

By looking at the code, the changes looks good to me. No manual testing is required for now. We will check the build results further.

If you know any concrete manual step to reproduce, can you please mention the same.

Thank you!

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests EE

[engcom-Charlie]

As per this, moving this PR to Extended Testing as the build is failing.

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

@magento run Integration Tests, Unit Tests

[hostep]

If you know any concrete manual step to reproduce, can you please mention the same.

I'm not sure what you mean with this question? Could you elaborate a bit?

[engcom-Charlie]

Moving this PR to Merge in Progress as build is green

If you know any concrete manual step to reproduce, can you please mention the same.

I'm not sure what you mean with this question? Could you elaborate a bit?

If in case, you might know the exact area/feature where this modified/deleted code was getting used, we can check those features manually.

But for now, as I have mentioned; code looks good to me, hence moving this PR to Merge in Progress as build is green.

[ihor-sviziev]

Thanks for cleanup!
Would be great to clean also

• checks for PHP < 8.1 https://github.com/search?q=repo%3Amagento%2Fmagento2%20PHP_VERSION&type=code
• hhvm-related things (AFAIK it's not supported for a long time) https://github.com/search?q=repo%3Amagento%2Fmagento2%20hhvm&type=code

[hostep]

Makes sense indeed @ihor-sviziev.
I currently lack the time to deal with those, but will try to keep it in the back of my mind unless someone else picks it up.

[engcom-Charlie]

@magento create issue

[hostep]

@engcom-Charlie: this is very confusing, we should create a new issue with a good description based on Ihor's comments

[ihor-sviziev]

@hostep I just created task for that #39362

[engcom-Charlie]

@magento create issue

Hi @hostep and @ihor-sviziev,

This issue created is for current PR as there were no issue attached as a part of process. So we have created it.

@ihor-sviziev #39362 will be consider as a new issue for the comments you mentioned in here.