Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Removes some code for PHP versions we no longer support. #39361

Closed
2 of 5 tasks
m2-assistant bot opened this issue Nov 13, 2024 · 3 comments · Fixed by #39202
Closed
2 of 5 tasks

[Issue] Removes some code for PHP versions we no longer support. #39361

m2-assistant bot opened this issue Nov 13, 2024 · 3 comments · Fixed by #39202
Assignees
Labels
Area: Framework Component: Framework/Component Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 13, 2024

This issue is automatically created based on existing pull request: #39202: Removes some code for PHP versions we no longer support.


Description (*)

Found some code in the codebase that no longer makes sense if we only support PHP 8.2 (soon 8.3?) and higher:

Related Pull Requests

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

  1. Check that the changed classes still function like they should function

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 13, 2024
@engcom-Charlie engcom-Charlie added Component: Framework/Component Area: Framework Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 13, 2024
@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Framework and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Area: Framework labels Nov 13, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13348 is successfully created for this GitHub issue.

Copy link
Author

m2-assistant bot commented Nov 13, 2024

✅ Confirmed by @engcom-Charlie. Thank you for verifying the issue.
Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-13348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: Framework/Component Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants