-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zip_codes.xml #29972
Update zip_codes.xml #29972
Conversation
Changed regex for zipcodes from Brazil. All zipcode must have 8 positions, with or without dash
Hi @marcostrama. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @marcostrama , please, sign Adobe CLA, otherwise, we can't process your pull request |
@magento create issue |
@sidolov just signed, thanks |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcostrama please, take a look a failed integration test, it's related to the changes
@magento run all tests |
Hi @sidolov can you give a help here? Functional tests failed with a message:
Appears to not be related with my changes, maybe some authentication failed for the test. I'm new at this project and I don't now how to proceed. thanks |
Hi @marcostrama , failures did not cause by your changes, looks like the problem with ASI tests. There is no action required from your side! |
Hi @sidolov, thank you for the review.
|
@marcostrama thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
@magento run all tests |
Hi @marcostrama, thank you for your contribution! |
Changed regex for zipcodes from Brazil. All zipcode must have 8 positions, with or without dash
Description (*)
Changed the regex to force 8 digits for zipcode in Brazil
Related Pull Requests
n/a
Fixed Issues (if relevant)
Didn't found issue but a lot of people asking for help in foruns
Manual testing scenarios (*)
Format of zipcodes in Brazil: 99999-999 or 99999999
Questions or comments
First contribution to Magento, please let me know if I need to provide more info
Contribution checklist (*)
Resolved issues: