Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zip_codes.xml #29972

Merged
merged 5 commits into from
Sep 23, 2020
Merged

Conversation

marcostrama
Copy link
Contributor

@marcostrama marcostrama commented Sep 10, 2020

Changed regex for zipcodes from Brazil. All zipcode must have 8 positions, with or without dash

Description (*)

Changed the regex to force 8 digits for zipcode in Brazil

Related Pull Requests

n/a

Fixed Issues (if relevant)

Didn't found issue but a lot of people asking for help in foruns

Manual testing scenarios (*)

Format of zipcodes in Brazil: 99999-999 or 99999999

  1. Put any number less than 8 digits (ex: 01001) - ERROR
  2. Put a number with 8 digits, without dash (ex: 01001-001) - OK
  3. Put a number with 5 digits, a dash and more 3 digits (ex: 01001-001) - OK

Questions or comments

First contribution to Magento, please let me know if I need to provide more info

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [N/A] All new or changed code is covered with unit/integration tests (if applicable)
  • [N/A] All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Update zip_codes.xml #29984: Update zip_codes.xml

Changed regex for zipcodes from Brazil. All zipcode must have 8 positions, with or without dash
@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2020

Hi @marcostrama. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sidolov
Copy link
Contributor

sidolov commented Sep 10, 2020

Hi @marcostrama , please, sign Adobe CLA, otherwise, we can't process your pull request

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 10, 2020
@sidolov
Copy link
Contributor

sidolov commented Sep 10, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Sep 10, 2020
2 tasks
@marcostrama
Copy link
Contributor Author

@sidolov just signed, thanks

@sidolov
Copy link
Contributor

sidolov commented Sep 11, 2020

@magento run all tests

@VladimirZaets VladimirZaets self-assigned this Sep 11, 2020
Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcostrama please, take a look a failed integration test, it's related to the changes

@marcostrama
Copy link
Contributor Author

@magento run all tests

@marcostrama
Copy link
Contributor Author

Hi @sidolov can you give a help here? Functional tests failed with a message:

SUITE PRECONDITION FAILED:
Waited for 60 secs but text 'auth[code=' still not found

Appears to not be related with my changes, maybe some authentication failed for the test. I'm new at this project and I don't now how to proceed. thanks

@sidolov
Copy link
Contributor

sidolov commented Sep 16, 2020

Hi @marcostrama , failures did not cause by your changes, looks like the problem with ASI tests. There is no action required from your side!

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8220 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@marcostrama thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this Sep 21, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 21, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Put any number less than 8 digits

Before: ❌ Format of zipcodes in Brazil: 99999-999 or 99999

Screenshot from 2020-09-21 16-25-31

After: ✔️ Format of zipcodes in Brazil: 99999-999 or 99999999

2020-09-21_16-33

@engcom-Alfa
Copy link
Contributor

@magento run all tests

@engcom-Alfa engcom-Alfa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Sep 22, 2020
@engcom-Echo engcom-Echo self-assigned this Sep 22, 2020
@magento-engcom-team magento-engcom-team merged commit 573d5ca into magento:2.4-develop Sep 23, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2020

Hi @marcostrama, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Directory Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Risk: low Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Issue] Update zip_codes.xml
6 participants