Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Update zip_codes.xml #29984

Closed
2 tasks done
m2-assistant bot opened this issue Sep 10, 2020 · 2 comments · Fixed by #29972
Closed
2 tasks done

[Issue] Update zip_codes.xml #29984

m2-assistant bot opened this issue Sep 10, 2020 · 2 comments · Fixed by #29972
Labels
Component: Directory Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Sep 10, 2020 •
edited by engcom-Alfa
Loading

This issue is automatically created based on existing pull request: #29972: Update zip_codes.xml

Changed regex for zipcodes from Brazil. All zipcode must have 8 positions, with or without dash

Preconditions: (*)

Magento 2.4-develop
Changed the regex to force 8 digits for zipcode in Brazil

Related Pull Requests

n/a

Fixed Issues (if relevant)

Didn't found issue but a lot of people asking for help in forums

Steps to reproduce: (*)

Format of zipcodes in Brazil: 99999-999 or 99999999

  1. Put any number less than 8 digits (ex: 01001) - ERROR
  2. Put a number with 8 digits, without dash (ex: 01001-001) - OK
  3. Put a number with 5 digits, a dash and more 3 digits (ex: 01001-001) - OK

Actual Result: ✖️ It possible to use 5 digits ZIP code

Screenshot from 2020-09-21 16-25-31

Expected Result: ✔️ all zip codes for Brazil must have 8 digits

2020-09-21_16-33

Questions or comments

First contribution to Magento, please let me know if I need to provide more info

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [N/A] All new or changed code is covered with unit/integration tests (if applicable)
  • [N/A] All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Directory Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 10, 2020
@m2-assistant m2-assistant bot mentioned this issue Sep 10, 2020
Merged
3 tasks
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 10, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 21, 2020
@engcom-Alfa engcom-Alfa added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 21, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-37771 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: ready for dev and removed Progress: PR in progress labels Sep 21, 2020
@gabrieldagama gabrieldagama added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Sep 23, 2020
@gabrieldagama
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #29972 by @marcostrama in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Directory Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update zip_codes.xml marcostrama/magento2
3 participants
@gabrieldagama @magento-engcom-team @engcom-Alfa