Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] create AdminTaxRateGridOpenPageActionGroup #29007

Merged
merged 2 commits into from
Jul 29, 2020
Merged

[MFTF] create AdminTaxRateGridOpenPageActionGroup #29007

merged 2 commits into from
Jul 29, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Jul 6, 2020 •
edited by m2-assistant bot
Loading

This PR creates new action group AdminTaxRateGridOpenPageActionGroup

Resolved issues:

  1. resolves [Issue] [MFTF] create AdminTaxRateGridOpenPageActionGroup #29281: [MFTF] create AdminTaxRateGridOpenPageActionGroup

@m2-assistant
Copy link

m2-assistant bot commented Jul 6, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@Usik2203
Copy link
Contributor Author

Usik2203 commented Jul 6, 2020

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

rogyar
rogyar requested changes Jul 6, 2020
View reviewed changes
app/code/Magento/Tax/Test/Mftf/ActionGroup/AdminTaxRateGridOpenPageActionGroup.xml

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminTaxRateGridOpenPageActionGroup">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to rename it, so we have a verb-action after the area name. Most likely, developer will look rather for AdminOpen... than for AdminTax (since the entire module is about tax).

Suggested change
<actionGroup name="AdminTaxRateGridOpenPageActionGroup">
<actionGroup name="AdminOpenTaxRateGridPageActionGroup">

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rogyar
Yes, I can do it . If I don't get another request from @lbajsarowicz to change name of action group to AdminTaxRateGridOpenPageActionGroup again 😄
Like it was in #28925
Should I do it ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. That's a very debatable topic from different perspectives. Let's leave it as it is for now.

@rogyar rogyar self-assigned this Jul 6, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Jul 6, 2020

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@engcom-Charlie engcom-Charlie self-assigned this Jul 21, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7881 has been created to process this Pull Request
✳️ @rogyar, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 25, 2020
@engcom-Alfa engcom-Alfa self-assigned this Jul 27, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 27, 2020
Closed
@engcom-Charlie engcom-Charlie added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jul 27, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 27, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 29, 2020
@slavvka
ENGCOM-7881: [MFTF] create AdminTaxRateGridOpenPageActionGroup #29007
5501129
@magento-engcom-team magento-engcom-team merged commit 08a023d into magento:2.4-develop Jul 29, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 29, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Checkout Component: Customer Component: SalesRule Component: Tax Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] create AdminTaxRateGridOpenPageActionGroup
6 participants
@Usik2203 @engcom-Charlie @magento-engcom-team @engcom-Alfa @rogyar @slavvka