Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] use action group for go to orders grid page #28925

Merged
merged 3 commits into from
Jul 16, 2020
Merged

[MFTF] use action group for go to orders grid page #28925

merged 3 commits into from
Jul 16, 2020

Conversation

Usik2203
Copy link
Contributor

This PR use <actionGroup ref="AdminOpenOrdersPageActionGroup" stepKey="goToOrders"/> for navigation on Orders page instead
<amOnPage url="{{AdminOrdersPage.url}}" stepKey="onOrdersPage"/>
<waitForPageLoad stepKey="waitForOrdersPageLoad"/>

@m2-assistant
Copy link

m2-assistant bot commented Jun 29, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@Usik2203
Copy link
Contributor Author

@magento run all tests

@rogyar rogyar self-assigned this Jun 29, 2020
@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 29, 2020
@rogyar
Copy link
Contributor

rogyar commented Jun 29, 2020

Hi @Usik2203. You don't need to run all tests in such cases since it might be really slow. It's enough to run the functional tests only.

lbajsarowicz
lbajsarowicz reviewed Jun 30, 2020
View reviewed changes
app/code/Magento/Sales/Test/Mftf/ActionGroup/AdminOpenOrdersPageActionGroup.xml Outdated

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminOpenOrdersPageActionGroup">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to have AdminOrdersPageOpenActionGroup? This way all other Action Groups related to Orders Page would be close in list to each other, even in Autosuggestion in PHPStorm:

Eg. when you start to type AdminOrderPage and you see hints:

  • OpenActionGroup
  • ClickFirstActionGroup
    etc. :)

@ghost ghost assigned lbajsarowicz Jun 30, 2020
@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B tests

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests B2B

lbajsarowicz
lbajsarowicz approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Perfect catch! Thank you for your input.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7764 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7764 has been created to process this Pull Request

@Usik2203 Usik2203 mentioned this pull request Jul 6, 2020
Merged
1 task
@engcom-Delta engcom-Delta self-assigned this Jul 10, 2020
@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@engcom-Kilo engcom-Kilo self-assigned this Jul 10, 2020
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Kilo
Copy link
Contributor

Failed Functional Tests B2B - not related to changes in this Pull Request.

@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 13, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jul 13, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 16, 2020
@slavvka
ENGCOM-7764: [MFTF] use action group for go to orders grid page #28925
28422ae
@magento-engcom-team magento-engcom-team merged commit f7dd7f1 into magento:2.4-develop Jul 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@rogyar rogyar

@engcom-Delta engcom-Delta

@engcom-Kilo engcom-Kilo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Backend Component: Checkout Component: Fedex Component: Multishipping Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.
7 participants
@Usik2203 @rogyar @magento-engcom-team @engcom-Delta @engcom-Kilo @lbajsarowicz @slavvka