Custom option type select - Allow modify list of single selection option types

[ihor-sviziev]

Description (*)

When I wanted to add one more type for "select" option group:

But there is no ability to mark own custom option type as "single select".

This PR adds ability to add own custom option type to this list by adding following code to di.xml file of own module:

    <type name="Magento\Catalog\Model\Product\Option\Type\Select">
        <arguments>
            <argument name="singleSelectionOptionTypes" xsi:type="array">
                <item name="my_custom_option_type" xsi:type="const">VendorName\ModuelName\Model\PathToMyModel::OPTION_TYPE_MY_CUSTOM_OPTION_TYPE</item>
            </argument>
        </arguments>
    </type>

This method is used in a lot of places, for example during validating custom option values during adding product to cart.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[ihor-sviziev]

Hi @rodrigowebjump,
Looks like you approved PR to 2.2-develop branch twice, but didn’t approved this one

[magento-engcom-team]

Hi @rodrigowebjump, thank you for the review.
ENGCOM-4588 has been created to process this Pull Request

[nmalevanec]

@ihor-sviziev, could you please clarify, why we need default values here, cause we already have them in di.xml?
Also, here we have numeric array, and in di.xml we have associative array for default values.

[ihor-sviziev]

Hi @nmalevanec,
It's needed for backward compatiblity, when last argument will not be sent. For instance when someone extended this class in his code when this attribute was missing.

About numeric array VS associative array - ok, will unify them

[sidolov]

Hi @ihor-sviziev , consider defining default arguments in the di.xml, with this approach this parameter will become configurable instead of hardcoded.

[ihor-sviziev]

Hi @sidolov,
As we discussed in Slack - it's needed for backward compatibility, in case if someone will extend this class & will not pass last argument in parent::__construct(...) - we have to have default value, similar as we're getting object from object manager by fallback.

[sidolov]

Hi @ihor-sviziev , consider defining default arguments in the di.xml, with this approach this parameter will become configurable instead of hardcoded.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-4588 has been created to process this Pull Request

[m2-assistant]

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.