Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Custom option type select - Allow modify list of single selection option types #21748

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Mar 14, 2019

Original Pull Request

#21744

Description (*)

When I wanted to add one more type for "select" option group:
screenshot1
But there is no ability to mark own custom option type as "single select".

This PR adds ability to add own custom option type to this list by adding following code to di.xml file of own module:

    <type name="Magento\Catalog\Model\Product\Option\Type\Select">
        <arguments>
            <argument name="singleSelectionTypes" xsi:type="array">
                <item name="my_custom_option_type" xsi:type="const">VendorName\ModuelName\Model\PathToMyModel::OPTION_TYPE_MY_CUSTOM_OPTION_TYPE</item>
            </argument>
        </arguments>
    </type>

This method is used in a lot of places, for example during validating custom option values during adding product to cart.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ihor-sviziev Thanks for your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-4509 has been created to process this Pull Request

Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ihor-sviziev
Thanks for your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-4509 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

On hold until #21744 would be merged

@ihor-sviziev
Copy link
Contributor Author

ihor-sviziev commented May 8, 2019

Original PR was merged

@m2-assistant
Copy link

m2-assistant bot commented May 12, 2019

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 12, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants