-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Custom option type select - Allow modify list of single selection option types #21748
Conversation
Hi @ihor-sviziev. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ihor-sviziev Thanks for your contribution.
Hi @rodrigowebjump, thank you for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ihor-sviziev
Thanks for your contribution.
Hi @rodrigowebjump, thank you for the review. |
On hold until #21744 would be merged |
Original PR was merged |
Hi @ihor-sviziev, thank you for your contribution! |
… of single selection option types #21748
Original Pull Request
#21744
Description (*)
When I wanted to add one more type for "select" option group:
But there is no ability to mark own custom option type as "single select".
This PR adds ability to add own custom option type to this list by adding following code to di.xml file of own module:
This method is used in a lot of places, for example during validating custom option values during adding product to cart.
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
N/A
Contribution checklist (*)