Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3-develop] [ForwardPort] Port of #15020 Update Gallery Template to handle boolean config Variables #15022

Merged
merged 1 commit into from
May 9, 2018
Merged

[2.3-develop] [ForwardPort] Port of #15020 Update Gallery Template to handle boolean config Variables #15022

merged 1 commit into from
May 9, 2018

Commits on May 5, 2018

  1. [2.3-develop] [ForwardPort] Port of #15020 Update Gallery Template to… 

    … handle boolean config Variables

Due to changes implemented in the resolution to #12285, boolean configuration variables are now properly typed booleans, instead of the strings "true" and "false".

Without this fix applied, config vals that were true were being output in the gallery template javascript as : 1 and values that were false were being output as :

This causes javascript errors for any item that is set to false.
    gwharton committed May 5, 2018
    Configuration menu
    Copy the full SHA
    163d4cc View commit details
    Browse the repository at this point in the history