[2.3-develop] [ForwardPort] Port of #15020 Update Gallery Template to handle boolean config Variables #15022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handle boolean config Variables Due to changes implemented in the resolution to #12285, boolean configuration variables are now properly typed booleans, instead of the strings "true" and "false". Without this fix applied, config vals that were true were being output in the gallery template javascript as : 1 and values that were false were being output as : This causes javascript errors for any item that is set to false.
|
Hi, @gwharton , I took your PR into processing, thank you for collaboration. |
This was referenced May 9, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
May 9, 2018
…y Template to handle boolean config Variables #15022
|
Hi @gwharton. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes implemented in the resolution to #12285, boolean configuration variables are now properly typed booleans, instead of the strings "true" and "false". This fix was applied to 2.2-develop only. Pull request #15021 applies the fix to 2.3-develop, hence this is now required in 2.3-develop aswell.
If we don't apply PR #15021 and this PR to 2.3-develop, then 2.2 and 2.3 will become horribly out of sync.
Fixed Issues (if relevant)
Contribution checklist