Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Foward-Port of #14156] Add website- and storeview-code in stores admin grid #14157

Merged
merged 3 commits into from
Mar 23, 2018

Conversation

aschrammel
Copy link

This PR is a forward-port of PR #14156 adds the webiste- and storeview-code in the stores admin grid like in Magento 1 stores overview.

Description

The PR joins additionally the code field from the store table to the admin grids row and adds the website code as well as the store view code in the respective renderers.

Fixed Issues (if relevant)

/

Manual testing scenarios

  1. Go to "Stores" > "Settings / All Stores"
  2. Before applying the PR there are only listed Website, Store and StoreView by their names
  3. After applying the PR there are the respective codes shown beneath the Website and StoreView names

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Add website- and storeview-code in stores Admin-Grid.
Andreas Schrammel added 2 commits March 17, 2018 14:21
Add store code in store admin grid.
Make "Code" string translateable. Translation for "Code" is already
contained in i18n/en_US.csv (Line 101).
@mzeis
Copy link
Contributor

mzeis commented Mar 23, 2018

@magento-engcom-team give me new test instance

@magento-engcom-team
Copy link
Contributor

Hi @mzeis, here is your new test Magento instance

Copy link
Contributor

@mzeis mzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, thanks!

@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mzeis, thank you for the review.
ENGCOM-1035 has been created to process this Pull Request

@mzeis
Copy link
Contributor

mzeis commented Mar 24, 2018

Hi @aschrammel, your forward-port has been merged into 2.3-develop. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants