Add website- and storeview-code in stores admin grid #14156

aschrammel · 2018-03-17T10:38:41Z

This PR adds the webiste- and storeview-code in the stores admin grid like in Magento 1 stores overview.

Description

The PR joins additionally the code field from the store table to the admin grids row and adds the website code as well as the store view code in the respective renderers.

Fixed Issues (if relevant)

Manual testing scenarios

Go to "Stores" > "Settings / All Stores"
Before applying the PR there are only listed Website, Store and StoreView by their names
After applying the PR there are the respective codes shown beneath the Website and StoreView names

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

Add website- and storeview-code in stores Admin-Grid.

mzeis · 2018-03-17T13:01:20Z

Hi @aschrammel,

thank you very much for your contribution! Would you consider adding the store name, too?

aschrammel · 2018-03-17T13:16:59Z

Hi @mzeis,

thanks for your feedback.
I think you mean the store code, as the name is already shown - am I right?

mzeis · 2018-03-17T13:18:47Z

@aschrammel Exactly :)

Add store code in store admin grid.

aschrammel · 2018-03-17T13:23:13Z

@mzeis Done :)

mzeis · 2018-03-18T09:39:45Z

@magento-engcom-team give me new test instance

magento-engcom-team · 2018-03-18T09:41:41Z

Hi @mzeis, here is your new test Magento instance

mzeis · 2018-03-18T10:12:00Z

app/code/Magento/Backend/Block/System/Store/Grid/Render/Group.php

@@ -27,6 +27,7 @@ public function render(\Magento\Framework\DataObject $row)
        $this->getUrl('adminhtml/*/editGroup', ['group_id' => $row->getGroupId()]) .
        '">' .
        $this->escapeHtml($row->getData($this->getColumn()->getIndex())) .
-        '</a>';
+        '</a><br />'
+        . '(Code: ' . $row->getGroupCode() . ')';


@aschrammel Please can you make "Code" translatable in all 3 places (like "Edit Store" here: Group.php and en_US.csv?

Then we should be good to go. Thanks!

Make "Code" string translateable. Translation for "Code" is already contained in i18n/en_US.csv (Line 101).

…develop

aschrammel · 2018-03-19T07:00:02Z

@mzeis Code is translatable now 🌐

The translation in en_US.csv is already given on line 101.

mzeis · 2018-03-19T17:42:53Z

@magento-engcom-team give me new test instance

magento-engcom-team · 2018-03-19T17:43:40Z

Hi @mzeis, here is your new test Magento instance

mzeis · 2018-03-19T17:50:19Z

@aschrammel Thanks for you improvements, looking good! 👍 I'm handing over to QA & merging.

magento-engcom-team · 2018-03-19T17:51:57Z

Hi @mzeis, thank you for the review.
ENGCOM-968 has been created to process this Pull Request

aschrammel · 2018-03-20T18:02:46Z

@magento-engcom-team thanks for acceptance 😄
In #14157 is the respective forward port to 2.3 if wanted.

mzeis · 2018-03-20T21:44:57Z

Thanks! I'll process it once the merge for this one is completed :)

mzeis · 2018-03-23T08:01:19Z

Hi @aschrammel, thanks again for your PR! It has been merged into 2.2-develop. We now can proceed with #14157.

…in stores admin grid #14157 - Merge Pull Request #14157 from aschrammel/magento2:2.3-develop - Merged commits: 1. 6f73126 2. 1e5745d 3. 8004cc5

…in stores admin grid #14157

@jonathanKingston

Accepted Public Pull Requests: - #14270: Remove usage of $.browser as it's unused and deprecated in jQuery. Fixes #14267 (by @jonathanKingston) - #14157: [Foward-Port of #14156] Add website- and storeview-code in stores admin grid (by @aschrammel) - #14218: Removing unused legacy price code (by @jonathanKingston) - #14173: 2.3 devel 14172 set timeout (by @jonathanKingston) Fixed GitHub Issues: - #14267: Use of deprecated $.browser (reported by @jonathanKingston) has been fixed in #14270 by @jonathanKingston in 2.3-develop branch Related commits: 1. 6c46def - #14172: Remove use of setTimeout eval (reported by @jonathanKingston) has been fixed in #14173 by @jonathanKingston in 2.3-develop branch Related commits: 1. e501f67 2. 0684b13

✨ Add website- and storeview-code

8611f7a

Add website- and storeview-code in stores Admin-Grid.

aschrammel mentioned this pull request Mar 17, 2018

[Foward-Port of #14156] Add website- and storeview-code in stores admin grid #14157

Merged

4 tasks

mzeis self-assigned this Mar 17, 2018

mzeis added improvement Admin Panel Release Line: 2.2 labels Mar 17, 2018

mzeis added the Progress: needs update label Mar 17, 2018

👌 Add store code

fb5e007

Add store code in store admin grid.

mzeis removed the Progress: needs update label Mar 18, 2018

mzeis suggested changes Mar 18, 2018

View reviewed changes

mzeis added the Progress: needs update label Mar 18, 2018

Andreas Schrammel added 2 commits March 19, 2018 07:54

👌 🌐 Make "Code" translatable

fe31fa4

Make "Code" string translateable. Translation for "Code" is already contained in i18n/en_US.csv (Line 101).

🔀 Merge branch '2.2-develop' of github.com:magento/magento2 into 2.2-…

f5a89e8

…develop

mzeis removed the Progress: needs update label Mar 19, 2018

mzeis approved these changes Mar 19, 2018

View reviewed changes

magento-engcom-team added this to the March 2018 milestone Mar 19, 2018

magento-engcom-team added the Progress: accept label Mar 20, 2018

magento-engcom-team merged commit f5a89e8 into magento:2.2-develop Mar 23, 2018

magento-engcom-team pushed a commit that referenced this pull request Mar 23, 2018

ENGCOM-968: Add website- and storeview-code in stores admin grid #14156

0070629

namlier mentioned this pull request Mar 23, 2018

[Forwardport] Add website- and storeview-code in stores admin grid #14285

Closed

4 tasks

magento-engcom-team pushed a commit that referenced this pull request Mar 23, 2018

ENGCOM-1035: [Foward-Port of #14156] Add website- and storeview-code …

dc02f8d

…in stores admin grid #14157

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add website- and storeview-code in stores admin grid #14156

Add website- and storeview-code in stores admin grid #14156

aschrammel commented Mar 17, 2018

mzeis commented Mar 17, 2018

aschrammel commented Mar 17, 2018 •

edited

Loading

mzeis commented Mar 17, 2018

aschrammel commented Mar 17, 2018

mzeis commented Mar 18, 2018

magento-engcom-team commented Mar 18, 2018

mzeis Mar 18, 2018

aschrammel commented Mar 19, 2018 •

edited

Loading

mzeis commented Mar 19, 2018

magento-engcom-team commented Mar 19, 2018

mzeis commented Mar 19, 2018

magento-engcom-team commented Mar 19, 2018

aschrammel commented Mar 20, 2018

mzeis commented Mar 20, 2018

mzeis commented Mar 23, 2018

Add website- and storeview-code in stores admin grid #14156

Add website- and storeview-code in stores admin grid #14156

Conversation

aschrammel commented Mar 17, 2018

Description

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

mzeis commented Mar 17, 2018

aschrammel commented Mar 17, 2018 • edited Loading

mzeis commented Mar 17, 2018

aschrammel commented Mar 17, 2018

mzeis commented Mar 18, 2018

magento-engcom-team commented Mar 18, 2018

mzeis Mar 18, 2018

Choose a reason for hiding this comment

aschrammel commented Mar 19, 2018 • edited Loading

mzeis commented Mar 19, 2018

magento-engcom-team commented Mar 19, 2018

mzeis commented Mar 19, 2018

magento-engcom-team commented Mar 19, 2018

aschrammel commented Mar 20, 2018

mzeis commented Mar 20, 2018

mzeis commented Mar 23, 2018

aschrammel commented Mar 17, 2018 •

edited

Loading

aschrammel commented Mar 19, 2018 •

edited

Loading