Add validation for number of street lines #12013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkublytskyi
added
Release Line: 2.2
2.2.x
bug report
Component: Checkout
Component: Config
Reproduced on 2.1.x
vkublytskyi
suggested changes
Nov 4, 2017
| @@ -198,7 +198,8 @@ | |||
| <field id="street_lines" translate="label comment" sortOrder="10" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1"> | |||
| <label>Number of Lines in a Street Address</label> | |||
| <backend_model>Magento\Customer\Model\Config\Backend\Address\Street</backend_model> | |||
| <comment>Leave empty for default (2). Valid range: 1-4</comment> | |||
| <comment>Valid range: 1-4</comment> | |||
| <validate>validate-digits validate-digits-range digits-range-1-4</validate> | |||
There was a problem hiding this comment.
Please add also required-entry to not allow blank field
|
done @vkublytskyi |
magento-team
pushed a commit
that referenced
this pull request
Nov 6, 2017
magento-team
pushed a commit
that referenced
this pull request
Nov 6, 2017
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-83278: Add validation for number of street lines #12013 - MAGETWO-83277: [backport 2.2] Magento 2 Store Code validation regex: doesn't support uppercase letters in store code #12011 - MAGETWO-82991: Product attribute creation page handles Storefront tab visibility wrong #11770 - MAGETWO-82976: Update wrong layout update xml handle installed in CMS Home Page by d… #11863 - MAGETWO-82952: Check attribute unique between same fields in magento commerce #11620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shipping address lines dissapear when street_lines on customer configuration is set to 0.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist