Update wrong layout update xml handle installed in CMS Home Page by default #11863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanners
approved these changes
Oct 30, 2017
adrian-martinez-interactiv4
changed the title
4 tasks
magento-team
added
Progress: needs update
Progress: accept
and removed
Progress: needs update
labels
magento-team
pushed a commit
that referenced
this pull request
Nov 6, 2017
magento-team
pushed a commit
that referenced
this pull request
Nov 6, 2017
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-83278: Add validation for number of street lines #12013 - MAGETWO-83277: [backport 2.2] Magento 2 Store Code validation regex: doesn't support uppercase letters in store code #12011 - MAGETWO-82991: Product attribute creation page handles Storefront tab visibility wrong #11770 - MAGETWO-82976: Update wrong layout update xml handle installed in CMS Home Page by d… #11863 - MAGETWO-82952: Check attribute unique between same fields in magento commerce #11620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preinstalled xml layout update handle in Home Page is invalid, element action is not expected anymore under referenceContainer node:
Exception handling for this validation will be done when changes from PR #11857 are applied.
Description
This legacy code shows a demo of how can be removed
right.reports.product.viewedandright.reports.product.comparedfrom right column, but it is outdated; the instructions are not valid and referenced blocks have changed.This PR suggest changing that preinstalled layout update handle, adapting reference to compared block and removing the viewed block reference, since this last one is now handled via widget and is not at the right column by default, so there is no need to try to remove it:
Contribution checklist
Related Pull Requests
#11891