Fix PageCache: async rendering of blocks can corrupt layout cache #8554 #9050 #11174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ento#8554 magento#9050 Adapted page cache tests
…ento#8554 magento#9050 Update additional pagecache layout handle name
Refactored original solution, implemented cache keys for layout to be able to generate different unique cache ids also based on possibly added cache keys
Refactored original solution, implemented cache keys for layout to be able to generate different unique cache ids also based on possibly added cache keys
* upstream/develop: (2518 commits) MQE-279: Create repositories in magento organization MQE-279: Create repositories in magento organization MQE-279: Create repositories in magento organization Deliver magento-partners/magento2ce#25: fixed static tests failures magento#10930 getcachetags for price issue Fixed Typo Mistake in comment. Add escaping of js translation version MAGETWO-72469: Merge 2.2-develop into develop magento#10789: enable universal use of modal and tab_group - Coding style updated magento#10848: added query param to url build - Test Updated Deprecated Magento\Store\Model\Store::$_isAdminSecure MAGETWO-72401: fix jenkins unittest magento#10826: response condition order changes. - Updated coding style MAGETWO-70859: Inconsistent behaviour of Scheduled Changes cviking26_issue-9489 // syntax hotfix MAGETWO-72469: Merge 2.2-develop into develop MAGETWO-72469: Merge 2.2-develop into develop cviking26_issue-9489 // changed array declaration cviking26_issue-9489 // added query param to url build - description in magento#9489 MAGETWO-72046: Error processing your request when placing reorder for simple product of configurable if attribute is changed - for 2.2 ...
…ento#8554 magento#9050 magento#9560 Create cache key object to be injected separately with its own interface
…ento#8554 magento#9050 magento#9560 Renamed interface, LayoutCacheKeyInterface made optional in constructor, injected via di.xml, some other little fixes
…ento#8554 magento#9050 magento#9560 Adapted PageCache and Framework tests
…ento#8554 magento#9050 magento#9560 Adapted PageCache and Framework tests
…ento#8554 magento#9050 magento#9560 Adapted PageCache and Framework tests
…ento#8554 magento#9050 magento#9560 Adapted PageCache and Framework tests
…ento#8554 magento#9050 magento#9560 Adapted PageCache and Framework tests
|
@adrian-martinez-interactiv4 why did you close the #9560 ? |
|
@vrann because the PR was my first one, and was shot from the develop branch of my fork. I wanted to clean my fork repository, also prepare my local working copy to work with develop, 2.1-develop and 2.2-develop branches, keeping them always aligned with the main repository. I know I could have switched the base branch of the PR, but since I've automatized the rebasing of this branches against the main repository to keep them updated, original PR related with my develop branch got closed. |
magento-team
pushed a commit
that referenced
this pull request
Oct 5, 2017
adrian-martinez-interactiv4
deleted the
FR#FIX-PAGECACHE-LAYOUT-CACHE-KEY
branch
adrian-martinez-interactiv4
restored the
FR#FIX-PAGECACHE-LAYOUT-CACHE-KEY
branch
adrian-martinez-interactiv4
deleted the
FR#FIX-PAGECACHE-LAYOUT-CACHE-KEY
branch
|
Is there 2.2.x version of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with closed PR#9560
Description
This pull request expects to fix layout cache corruption due to async pagecache requests, when the async request generates a layout cacheId based on same handles as a cms page, but without loading the cms page associated, so cms page related layout updates get lost. Further explanation on issues #8554 and #9050. The testing scenario may sound weird, but it actually happens due to layout cache expiration, so layout cache expires but full page cache is still valid.
Fixed Issues
Manual testing scenarios
Adapted Tests
\Magento\PageCache\Test\Unit\Controller\Block\RenderTest::testExecute
\Magento\PageCache\Test\Unit\Controller\Block\EsiTest::testExecute
Expected Result
Page rendered correctly, as the first time.
Actual Result
Depending on included content, full blank page may be returned, but at least, it fails to apply page layout update handles, so block added via layout update is not shown.