Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomly getting an empty <body> that gets cached #9050

Closed
vlauria opened this issue Mar 29, 2017 · 6 comments
Closed

Randomly getting an empty <body> that gets cached #9050

vlauria opened this issue Mar 29, 2017 · 6 comments
Labels
bug report Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@vlauria
Copy link

vlauria commented Mar 29, 2017 •
edited by magento-engcom-team
Loading

Preconditions

  1. Magento CE 2.1.5 without sample data is installed.

Steps to reproduce

I do not know.
I'm having problems with a very basic Magento 2 install, with very few customizations or extensions.
We randomly get a completely empty tag on the home page that then gets cached on Varnish and the site is not accessible. All the contents etc are just fine (except for an empty <title>).
Cleaning cache and banning Varnish fixes the issue but it's a huge issue.
I haven't found a way to replicate this as it seems to happened randomly.
If I load something like /?test that bypasses cache, the page loads correctly.

Expected result

Homepage showed

Actual result

Blank page
@davidalger
Copy link
Member

@vlauria We've run into this issue on a couple EE builds, and the solution I believe was found in a patch which removed layout="admin-1column" from this file: https://github.com/magento/magento2/blob/develop/app/code/Magento/Ui/view/base/layout/default.xml

It's absolutely not an official answer, but we were told the following: The target release where this fix will be included is 2.1.8 - however this is subject to change. So you may want to use the following to patch your site in the mean time:

diff --git a/vendor/magento/module-ui/view/base/layout/default.xml b/vendor/magento/module-ui/view/base/layout/default.xml
index 7f2efbd..64d5f14 100644
--- a/vendor/magento/module-ui/view/base/layout/default.xml
+++ b/vendor/magento/module-ui/view/base/layout/default.xml
@@ -5,7 +5,7 @@
  * See COPYING.txt for license details.
  */
 -->
-<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" layout="admin-1column" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
+<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
     <body>
         <referenceContainer name="after.body.start">
             <block class="Magento\Ui\Block\Logger" name="logger" template="Magento_Ui::logger.phtml"/>

Closed
adrian-martinez-interactiv4 added a commit to adrian-martinez-interactiv4/magento2 that referenced this issue May 9, 2017
@adrian-martinez-interactiv4
Fix PageCache: async rendering of blocks can corrupt layout cache mag…
bf7df0d 
…ento#8554 magento#9050

Fix PSR-2 standard
adrian-martinez-interactiv4 added a commit to adrian-martinez-interactiv4/magento2 that referenced this issue May 9, 2017
@adrian-martinez-interactiv4
Fix PageCache: async rendering of blocks can corrupt layout cache mag…
7feba6c 
…ento#8554 magento#9050

Adapted page cache tests
adrian-martinez-interactiv4 added a commit to adrian-martinez-interactiv4/magento2 that referenced this issue May 10, 2017
@adrian-martinez-interactiv4
Fix PageCache: async rendering of blocks can corrupt layout cache mag…
1bb25ed 
…ento#8554 magento#9050

Update additional pagecache layout handle name
@miguelbalparda
Copy link
Contributor

#9560 seems to fix this issue, can you try that fix and report back? I'd like to merge that PR but I will need some help from you 😄

Closed
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-69018

@magento-team magento-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report develop labels Jul 31, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
adrian-martinez-interactiv4 added a commit to adrian-martinez-interactiv4/magento2 that referenced this issue Sep 21, 2017
@adrian-martinez-interactiv4
Fix PageCache: async rendering of blocks can corrupt layout cache mag…
bd6ed7c 
…ento#8554 magento#9050 magento#9560

Create cache key object to be injected separately with its own interface
adrian-martinez-interactiv4 added a commit to adrian-martinez-interactiv4/magento2 that referenced this issue Sep 22, 2017
@adrian-martinez-interactiv4
Fix PageCache: async rendering of blocks can corrupt layout cache mag…
c6e2b39 
…ento#8554 magento#9050 magento#9560

Renamed interface, LayoutCacheKeyInterface made optional in constructor, injected via di.xml, some other little fixes
adrian-martinez-interactiv4 added a commit to adrian-martinez-interactiv4/magento2 that referenced this issue Sep 22, 2017
@adrian-martinez-interactiv4
Fix PageCache: async rendering of blocks can corrupt layout cache mag…
3cc51dc 
…ento#8554 magento#9050 magento#9560

Adapted PageCache and Framework tests
adrian-martinez-interactiv4 added a commit to adrian-martinez-interactiv4/magento2 that referenced this issue Sep 22, 2017
@adrian-martinez-interactiv4
Fix PageCache: async rendering of blocks can corrupt layout cache mag…
2ae9c26 
…ento#8554 magento#9050 magento#9560

Adapted PageCache and Framework tests
adrian-martinez-interactiv4 added a commit to adrian-martinez-interactiv4/magento2 that referenced this issue Sep 22, 2017
@adrian-martinez-interactiv4
Fix PageCache: async rendering of blocks can corrupt layout cache mag…
516b529 
…ento#8554 magento#9050 magento#9560

Adapted PageCache and Framework tests
adrian-martinez-interactiv4 added a commit to adrian-martinez-interactiv4/magento2 that referenced this issue Sep 22, 2017
@adrian-martinez-interactiv4
Fix PageCache: async rendering of blocks can corrupt layout cache mag…
efa3edb 
…ento#8554 magento#9050 magento#9560

Adapted PageCache and Framework tests
adrian-martinez-interactiv4 added a commit to adrian-martinez-interactiv4/magento2 that referenced this issue Sep 22, 2017
@adrian-martinez-interactiv4
Fix PageCache: async rendering of blocks can corrupt layout cache mag…
3f60168 
…ento#8554 magento#9050 magento#9560

Adapted PageCache and Framework tests
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Oct 1, 2017
Merged
magento-team pushed a commit that referenced this issue Oct 5, 2017
@vrann
MAGETWO-80647: Fix PageCache: async rendering of blocks can corrupt l…
f72db1b 
…ayout cache #8554 #9050 #11174

 - Merge Pull Request #11174 from adrian-martinez-interactiv4/magento2:FR#FIX-PAGECACHE-LAYOUT-CACHE-KEY
 - Merged commits:
   1. 3bdfa1b
   2. 5a6a000
   3. bf7df0d
   4. 7feba6c
   5. 1bb25ed
   6. 0e830c1
   7. 8a92e46
   8. 0a69b5b
   9. bd6ed7c
   10. c6e2b39
   11. 3cc51dc
   12. 2ae9c26
   13. 516b529
   14. efa3edb
   15. 3f60168
magento-team pushed a commit that referenced this issue Oct 5, 2017
MAGETWO-80647: Fix PageCache: async rendering of blocks can corrupt l…
da3210d 
…ayout cache #8554 #9050 #11174
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-80647

@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 3, 2017
@okorshenko okorshenko removed the 2.1.x label Dec 14, 2017
@ghost ghost self-assigned this Nov 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-nazar. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost
Copy link

ghost commented Nov 19, 2018

Hi @vlauria The issue was re-tested and we can confirm that it was fixed on the 2.3 release branch. We closing this issue as fixed due to upcoming 2.3 release that will be available soon.

@ghost ghost closed this as completed Nov 19, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@davidalger @magento-team @miguelbalparda @okorshenko @vlauria @magento-engcom-team