Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gruntfile should not rely on PHP #1793

Closed
markshust opened this issue Sep 4, 2015 · 2 comments
Closed

Gruntfile should not rely on PHP #1793

markshust opened this issue Sep 4, 2015 · 2 comments

Comments

@markshust
Copy link
Contributor

I'm getting an odd bug when attaching a Magento 2 volume to a nodejs task runner container and executing grunt refresh:

gruntrefresh_1 | Running "exec:all" (exec) task
gruntrefresh_1 | grunt --force clean:blank
gruntrefresh_1 | >> /bin/sh: 1: php: not found
gruntrefresh_1 | >> Exited with code: 127.
gruntrefresh_1 | Warning: Task "exec:all" failed. Use --force to continue.
gruntrefresh_1 | 
gruntrefresh_1 | Aborted due to warnings.
gruntrefresh_1 | 
gruntrefresh_1 | 
gruntrefresh_1 | Execution Time (2015-09-04 18:36:10 UTC)
gruntrefresh_1 | loading tasks  1.2s  ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 97%
gruntrefresh_1 | exec:all       29ms  ▇▇ 2%
gruntrefresh_1 | Total 1.2s
gruntrefresh_1 | 
magento2_gruntrefresh_1 exited with code 3

It appears that grunt is looking for PHP, when I don't believe PHP should be required at all to run a grunt refresh (strictly nodejs, right?). I tried looking for exec:all to fix, but wasn't successful...

@markshust
Copy link
Contributor Author

Ahh... never mind. It appears ./bin/magento is building out static asset content. I don't think we can get around this right now...

deploy = spawn('php', ['bin/magento', 'setup:static-content:deploy']);

In future, I believe we should look into decoupling php from nodejs tasks... seems really awkward.

@gotbahn
Copy link

gotbahn commented Sep 4, 2015

It's pretty organic if think about Magento import directive

But if you don't wanna mix a worlds, you can always setup own way with separate theme and own Grunt config. It's not a mandatory.

okorshenko pushed a commit that referenced this issue Dec 1, 2017
Public Pull Requests

#12207 11882: It's not possible to enable "log to file" (debugging) in production mode. Psr logger debug method does not work by the default in developer mode. by @nmalevanec
#11926 8255: Export Products action doesn't consider hide_for_product_page value. by @nmalevanec
#11485 do the stock check on default level because the stock on website leve… by @joost-florijn-kega
#11388 Fix #11236: Web Setup Wizard Icon Inconsistency by @dverkade
#11323 Defaulting missing alt-text for a product to use the product name. by @brobie

Fixed Public Issues

#11509 Psr logger debug method does not work by the default in developer mode
#11882 It's not possible to enable "log to file" (debugging) in production mode
#8255 Export Products action doesn't consider hide_for_product_page value
#11484 Visual Merchandiser show prices of out of stock simple products for the associated configurable product.
#11236 Web Setup Wizard Icon Inconsistency
#9931 Empty image alt-text & missing alt attribute on product detail page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants