Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11882: It's not possible to enable "log to file" (debugging) in production mode. Psr logger debug method does not work by the default in developer mode. #12207

Merged
merged 10 commits into from
Dec 1, 2017

Conversation

nmalevanec
Copy link
Contributor

Description

Adds ability to enable "log to file" in production mode. Enable by default "log to file" in developer mode.

Fixed Issues (if relevant)

  1. It's not possible to enable "log to file" (debugging) in production mode #11882: It's not possible to enable "log to file" (debugging) in production mode
  2. Psr logger debug method does not work by the default in developer mode #11509: Psr logger debug method does not work by the default in developer mode

Manual testing scenarios

  1. Install Magento.
  2. Switch to developer mode: bin/magento deploy:mode:set developer.
  3. Login to admin.
  4. Navigate to Stores > Configuration > Advanced > Developer > Debug.
  5. Check "Log to File" set to Yes.
  6. Switch to production mode: bin/magento deploy:mode:set production.
  7. Navigate to Stores > Configuration > Advanced > Developer > Debug.
  8. Check "Log to File" set to No. You have ability to change "Log to File" to Yes.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…ction mode. Psr logger debug method does not work by the default in developer mode
@magento-engcom-team magento-engcom-team added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 13, 2017
@okorshenko okorshenko self-assigned this Nov 14, 2017
@okorshenko okorshenko added this to the November 2017 milestone Nov 14, 2017
…ction mode. Psr logger debug method does not work by the default in developer mode.
…ction mode. Psr logger debug method does not work by the default in developer mode.
…ction mode. Psr logger debug method does not work by the default in developer mode.
…ction mode. Psr logger debug method does not work by the default in developer mode.
…ction mode. Psr logger debug method does not work by the default in developer mode.
…ction mode. Psr logger debug method does not work by the default in developer mode.
@okorshenko okorshenko merged commit 3e86197 into magento:2.2-develop Dec 1, 2017
okorshenko pushed a commit that referenced this pull request Dec 1, 2017
…gging) in production mode. Psr logger debug method does not work by the default in developer mode. #12207
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Dec 1, 2017
@nmalevanec nmalevanec deleted the 11882 branch January 10, 2018 14:13
@keharper
Copy link
Contributor

keharper commented Jun 5, 2018

@nmalevanec I'm trying to determine how your contribution affects the developer documentation. Do any CLI commands now behave differently?

@nmalevanec
Copy link
Contributor Author

@keharper, bin/magento deploy:mode:set developer and bin/magento deploy:mode:set production now affects dev/debug/debug_logging value in such way:

Before:

Switching from default mode to production - dev/debug/debug_logging not affected.
Switching from default mode to developer - dev/debug/debug_logging not affected.
Switching from developer mode to production - dev/debug/debug_logging set to '0' and locked(there is no ability to set dev/debug/debug_logging to '1' via UI or CLI, even after switching back to developer mode).
Switching from production mode to developer - dev/debug/debug_logging not affected and may be locked to '0'.

After:

Switching from default mode to production - dev/debug/debug_logging set to '0' without lock. There is ability to enable it via admin UI or CLI.
Switching from default mode to developer - dev/debug/debug_logging set to '1' without lock. There is ability to disable it via admin UI or CLI.
Switching from developer mode to production - dev/debug/debug_logging set to '0' without lock. There is ability to enable it via admin UI or CLI.
Switching from production mode to developer - dev/debug/debug_logging set to '1' without lock. There is ability to disable it via admin UI or CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants