Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/3330 Metadata creation tool & Storage api #3334

Merged
merged 70 commits into from
Apr 4, 2022
Merged

Issue/3330 Metadata creation tool & Storage api #3334

merged 70 commits into from
Apr 4, 2022

Commits on Mar 11, 2022

  1. related to #3331, remove unused policy files

    @t83714
    t83714 committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    ccb5706 View commit details
    Browse the repository at this point in the history

  2. #3330 add access control aspect to distributions

    @t83714
    t83714 committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    3e4529c View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. fix: no need & should not return user's current org as root node -- i… 

    …t should be decided by auth policy
    @t83714
    t83714 committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    c1b6bd2 View commit details
    Browse the repository at this point in the history

  2. remove obsolete resource registry/record & relevant records defined… 

    … in schema v1.7
    @t83714
    t83714 committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    d11d3c0 View commit details
    Browse the repository at this point in the history

  3. remove obsolete object/dataset/published/updateLicenseInfo & `objec… 

    …t/dataset/published/updateNonLicenseInfo`
    @t83714
    t83714 committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    25040d9 View commit details
    Browse the repository at this point in the history

  4. re-setup default roles

    @t83714
    t83714 committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    147685f View commit details
    Browse the repository at this point in the history

  5. fix sql migration script

    @t83714
    t83714 committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    897743e View commit details
    Browse the repository at this point in the history

  6. fixed sql migration script: incorrect id

    @t83714
    t83714 committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    b4ee839 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. refine tune default roles setup

    @t83714
    t83714 committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    60aabbd View commit details
    Browse the repository at this point in the history

  2. more accurately control my dataset section access

    @t83714
    t83714 committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    65292fe View commit details
    Browse the repository at this point in the history

  3. explicitly remove 'object/dataset/published/updateLicenseInfo' & 'obj… 

    …ect/dataset/published/updateNonLicenseInfo' operation
    @t83714
    t83714 committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    a45c4d2 View commit details
    Browse the repository at this point in the history

  4. - remove userId based query so all datasets the user has access will … 

    …be shown.

- rename tab to Datasets from "My Datasets"
- hide add tab when user has no create permission
    @t83714
    t83714 committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    3483df0 View commit details
    Browse the repository at this point in the history

  5. check user access to metadata creation function by permissions to all… 

    …ow no-admin user access
    @t83714
    t83714 committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    f9e3a37 View commit details
    Browse the repository at this point in the history

  6. adjust draft dataset definition in policy: allow records without `dat… 

    …aset-draft` to be considered as a draft dataset (when publishing.state = "draft").
    @t83714
    t83714 committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    5f69586 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. add Read Org Units with own org units permission to default roles

    @t83714
    t83714 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    0328123 View commit details
    Browse the repository at this point in the history

  2. correct typo

    @t83714
    t83714 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    b623c74 View commit details
    Browse the repository at this point in the history

  3. - move record auth logic to parametered rule 

    - add rule for resource storage/bucket & storage/object (file)
    @t83714
    t83714 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    176ad03 View commit details
    Browse the repository at this point in the history

  4. #3333 Rename access-control aspect orgUnitOwnerId field to orgUnitId

    @t83714
    t83714 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    e83ca72 View commit details
    Browse the repository at this point in the history

  5. format the code

    @t83714
    t83714 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    bfea4f9 View commit details
    Browse the repository at this point in the history

  6. - skip ensure aspect for now 

    - adjustment for error message
    @t83714
    t83714 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    624d474 View commit details
    Browse the repository at this point in the history

  7. - add skipAuth option to storage api chart 

    - create AuthDecisionQueryClient and passing on to apiRouter
    @t83714
    t83714 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    eddc7cb View commit details
    Browse the repository at this point in the history

  8. fix policies: import breakdownOperationUri

    @t83714
    t83714 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    1ed3604 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/next' into issue/3330

    @t83714
    t83714 committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    7fb7d0b View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. - add registry api getByIdInFull 

    - apply new auth model enforcement to storage API
    @t83714
    t83714 committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    46bc984 View commit details
    Browse the repository at this point in the history

  2. related to #3335, remove /v0/storage/upload/{bucket}/{path} API

    @t83714
    t83714 committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    b9f74c4 View commit details
    Browse the repository at this point in the history

  3. fixed: registry router

    @t83714
    t83714 committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    b7ab276 View commit details
    Browse the repository at this point in the history

  4. fixed test cases

    @t83714
    t83714 committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    868c3b2 View commit details
    Browse the repository at this point in the history

  5. fixed: getUserId middleware incorrect retrieve userId from req

    @t83714
    t83714 committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    ee5086b View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. fix test cases

    @t83714
    t83714 committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    82a7caf View commit details
    Browse the repository at this point in the history

  2. remove obsolete auth test cases -- new test cases to be added

    @t83714
    t83714 committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    14a1a9c View commit details
    Browse the repository at this point in the history

  3. bump index version number

    @t83714
    t83714 committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    166445a View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. add presign url methods

    @t83714
    t83714 committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    1c1c41e View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. fix: create userId for storage api pod

    @t83714
    t83714 committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    a3ba4f3 View commit details
    Browse the repository at this point in the history

  2. - add storage resource / operations to sql migration file 

    - adjust require permission for upload
- remove `prettier` from storage-api module
    @t83714
    t83714 committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    007ea5f View commit details
    Browse the repository at this point in the history

  3. - restore POST /upload/:bucket* as we still need it for UI for now 

    - will remove it after switch to presigned url based upload
    @t83714
    t83714 committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    622abd2 View commit details
    Browse the repository at this point in the history

  4. add policy entry point for storage objects

    @t83714
    t83714 committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    c724bc8 View commit details
    Browse the repository at this point in the history

  5. adjust how auth decision context data is created for storage/object

    @t83714
    t83714 committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    38c8031 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2022

  1. adjust storage auth middleware logic

    @t83714
    t83714 committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    0731a46 View commit details
    Browse the repository at this point in the history

  2. make sure getDownloadUrl always generate valid s3 object keys from … 

    …file names.
    @t83714
    t83714 committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    6f4295b View commit details
    Browse the repository at this point in the history

  3. move getDownloadUrl to magda-typescript-common and rename to getStora… 

    …geUrl
    @t83714
    t83714 committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    976aa2c View commit details
    Browse the repository at this point in the history

  4. add test cases for getStorageUrl

    @t83714
    t83714 committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    c41e0f4 View commit details
    Browse the repository at this point in the history

  5. adjust storage related policies

    @t83714
    t83714 committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    65e258c View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. - code refactoring 

    - bug fix: authDecisionClient should set Content-Type header to json when post json data
    @t83714
    t83714 committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    e6a0ef2 View commit details
    Browse the repository at this point in the history

  2. - make sure delete storage response 200 when the storage object doesn… 

    …'t exist (without verify access control). We need this as it will make frontend error handling / implementation easier

- add more test cases
    @t83714
    t83714 committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    355370f View commit details
    Browse the repository at this point in the history

  3. - #3339 update DB migration script for default role setup 

    - fix comment typo in policy files
    @t83714
    t83714 committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    e453206 View commit details
    Browse the repository at this point in the history

  4. #3339 fix sql migration incorrect resource id

    @t83714
    t83714 committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    b235334 View commit details
    Browse the repository at this point in the history

  5. use requirePermission in storageAuthMiddleware

    @t83714
    t83714 committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    91862b7 View commit details
    Browse the repository at this point in the history

  6. - fix: orgUnit read API should use partial eval 

    - fix: AspectQueryValue: the default always run in a switch block
- fix: getTableColumnName
- fix: add round bracet to sql generated from auth decision
- update CustodianDropdown  & OrgUnitDropdown error text
    @t83714
    t83714 committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    17bcbc8 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. increase registry request timeout time to 60s (from 30s)

    @t83714
    t83714 committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    7e68718 View commit details
    Browse the repository at this point in the history

  2. add rsuite default theme to metadata creation tool

    @t83714
    t83714 committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    86c11ae View commit details
    Browse the repository at this point in the history

  3. decideion endpoint will print execution time in logs when debug mode … 

    …is on
    @t83714
    t83714 committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    8a25a9e View commit details
    Browse the repository at this point in the history

  4. - update helm docs 

    - use custom rsuite css for setting panel as well
    @t83714
    t83714 committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    0de510c View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. #3340 speed up the opa AST evaluate by proactively set input. refer… 

    …ence as not resolvable
    @t83714
    t83714 committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    7d0d230 View commit details
    Browse the repository at this point in the history

  2. #3340 remove duplicated rules to reduce the processing time by 200ms

    @t83714
    t83714 committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    b89a801 View commit details
    Browse the repository at this point in the history

  3. #3340 add extra large response sample to decision endpoint test case

    @t83714
    t83714 committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    ac6e58e View commit details
    Browse the repository at this point in the history

  4. - upgrade redux to 4.1.2 

    - upgrade react-redux to 7.2.4
- OrgUnitsPage make sure user see current assigned orgunit as root
    @t83714
    t83714 committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    a6d1081 View commit details
    Browse the repository at this point in the history

  5. fix NestedSetModelQueryer table ref case issue

    @t83714
    t83714 committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    40b5a01 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. - use "@magda/typescript-common/dist/ServerError" instead to avoid du… 

    …plication

- add topDownPathTo api
    @t83714
    t83714 committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    98dd521 View commit details
    Browse the repository at this point in the history

  2. add more comments & test cases

    @t83714
    t83714 committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    2947dd0 View commit details
    Browse the repository at this point in the history

  3. - adjust the feature behinds the feature flags 

    - create a more generic orgUnit dropdown
- fix topDownPathTo api
    @t83714
    t83714 committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    55ab007 View commit details
    Browse the repository at this point in the history

  4. move custodianOrgUnitId & managingOrgUnitId to publishing aspect

    @t83714
    t83714 committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    c9a0c2e View commit details
    Browse the repository at this point in the history

  5. set default access level to `creatorOrgUnit" (within creator's orgnis… 

    …ational unit)
    @t83714
    t83714 committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    dd2516c View commit details
    Browse the repository at this point in the history

  6. dataset access control settings

    @t83714
    t83714 committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    666a50f View commit details
    Browse the repository at this point in the history

  7. enable edit page for non-admin users

    @t83714
    t83714 committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    ead4559 View commit details
    Browse the repository at this point in the history

  8. add nice loading bar for add/edit metadata tool

    @t83714
    t83714 committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    72d80b9 View commit details
    Browse the repository at this point in the history

  9. turned off approval workflow & publish to dga for test site deploymen… 

    …t (still on for master deployment)
    @t83714
    t83714 committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    09d27c3 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. fix should process file name before upload files

    @t83714
    t83714 committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    56d3c76 View commit details
    Browse the repository at this point in the history

  2. #3340 reduce no. of rules in PE result further by filter out "impossi… 

    …ble rules".

Plus, we will also filter out duplicate expressions.
    @t83714
    t83714 committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    c850404 View commit details
    Browse the repository at this point in the history

  3. #3340 update auth decision test case sample file

    @t83714
    t83714 committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    648b710 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2022

  1. update changes.md

    @t83714
    t83714 committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    8582752 View commit details
    Browse the repository at this point in the history