Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auth related legacy code #3331

Closed
5 tasks done
t83714 opened this issue Mar 11, 2022 · 3 comments · Fixed by #3389
Closed
5 tasks done

Remove auth related legacy code #3331

t83714 opened this issue Mar 11, 2022 · 3 comments · Fixed by #3389

Comments

@t83714
Copy link
Contributor

t83714 commented Mar 11, 2022

Remove auth related legacy code

Including:

  • Any code (both frontend & backend) related to authnReadPolicyId
  • Used Policy files: magda-opa/policies/object/registry
  • remove obsolete middleware & directives
  • remove unused OPA parser
  • remove obsolete resource / operations
@t83714
Copy link
Contributor Author

t83714 commented May 4, 2022

done all items except remove obsolete middleware & directives in PR: #3347.
Create the following tickets for remove obsolete middleware & directives:

@t83714
Copy link
Contributor Author

t83714 commented Jul 1, 2022

Re: above tickets:
When tackling those tickets, we probably want to:

  • Propose the design re: how API access map to the current auth “resource” / “operation” model
    • E.g. you can either create a new resource “api/xxxAPI” & operations e.g. “api/xxxApi/xxxoperation”
    • OR bind the access to defined “resource” e.g. an API to read dataset can request permission to defined “object/dataset/read”
  • Leverage existing auth middleware to replace existing “admin-only” middleware
    • withAuthDecision middleware is the base middleware can be used to ask generic auth decision from the policy engine
      • There are a few more specialised middlewares built on top of it (available in the same file) that you might also want to have a look
    • For anyone's interest, the scala version “withAuthDecision Akka Directive” is here

t83714 added a commit that referenced this issue Aug 5, 2022
- Related #3331, remove legacy middlewares
@t83714 t83714 linked a pull request Aug 5, 2022 that will close this issue
2 tasks
@t83714
Copy link
Contributor Author

t83714 commented Aug 8, 2022

closed via PR: #3390

@t83714 t83714 closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant