Fix issue of modal being opened twice - Rotate refreh icon while loading #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaun
suggested changes
Sep 14, 2017
| <span translate>mno_enterprise.templates.components.mnoe-tasks.compose_button_text</span> | ||
| <i class="fa fa-pencil-square-o" aria-hidden="true"></i> | ||
| </button> | ||
| <mno-dropdown-filter-selector filters="$ctrl.tasksFilters" selected="$ctrl.selectedTasksFilter" on-select="$ctrl.onSelectFilter($event)"></mno-dropdown-filter-selector> | ||
| <div class="refresh-tasks" ng-click="$ctrl.onRefreshTasks()"> | ||
| <i class="fa fa-refresh fa-2x fa-fw" aria-hidden="true"></i> | ||
| <div class="refresh-tasks" ng-click="$ctrl.onRefreshTasks()" ng-disabled="$ctrl.tasks.loading" ng-class="{'disabled': $ctrl.tasks.loading}"> |
There was a problem hiding this comment.
ng-disabled should be removed here
| color: @mno-tasks-column-sort-icon-active-color; | ||
| &:hover { | ||
| color: darken(@mno-tasks-column-sort-icon-active-color, 15%); | ||
| } | ||
| &.disabled { | ||
| opacity: 0.5; | ||
| pointer-events: none; |
There was a problem hiding this comment.
I would not recommend using pointer-events: none, it does not give the user any feedback and may feel like the page is frozen.
I recommend using cursor: progress or cursor: not-allowed. Here are the available pointer style examples: https://www.w3schools.com/cssref/tryit.asp?filename=trycss_cursor.
xaun
approved these changes
Sep 14, 2017
- Remove useless css - Use pointer not-allowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.