Apply code review comments

- Remove useless css - Use pointer not-allowed
maestrano · Sep 14, 2017 · a012611 · a012611
1 parent e28b8dd
commit a012611
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/app/components/mnoe-tasks/mnoe-tasks.html b/src/app/components/mnoe-tasks/mnoe-tasks.html
@@ -5,7 +5,7 @@
       <i class="fa fa-pencil-square-o" aria-hidden="true"></i>
     </button>
     <mno-dropdown-filter-selector filters="$ctrl.tasksFilters" selected="$ctrl.selectedTasksFilter" on-select="$ctrl.onSelectFilter($event)"></mno-dropdown-filter-selector>
-    <div class="refresh-tasks" ng-click="$ctrl.onRefreshTasks()" ng-disabled="$ctrl.tasks.loading"  ng-class="{'disabled': $ctrl.tasks.loading}">
+    <div class="refresh-tasks" ng-click="$ctrl.onRefreshTasks()" ng-class="{'disabled': $ctrl.tasks.loading}">
       <i class="fa fa-refresh fa-2x" aria-hidden="true" ng-class="{'fa-spin': $ctrl.tasks.loading}"></i>
     </div>
   </div>

diff --git a/src/app/components/mnoe-tasks/mnoe-tasks.less b/src/app/components/mnoe-tasks/mnoe-tasks.less
@@ -25,11 +25,7 @@ mnoe-tasks {
         }
         &.disabled {
           opacity: 0.5;
-          pointer-events: none;
-          > * {
-            opacity: 0.5;
-            pointer-events: none;
-          }
+          pointer: not-allowed;
         }
       }